[GEN-1950] Replace deprecated runCommand in Android docs with device.adb / passAudioAsMicrophoneInput#158
Draft
Joonil Kim (bartholomaeuskim) wants to merge 1 commit into
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
runCommandis deprecated in the New Flow API, but three Android docs still used it to invokeadband to play audio into the emulator microphone. This swaps those examples to the supporteddevicehelpers.ffplay …viarunCommand→device.passAudioAsMicrophoneInput({ data, durationSeconds }); the recording pull →device.adb(...). Renamed the "ffplay flags" section to "Options" (the helper wraps the flags) and addeddeviceto the full-sample import.runCommand("adb …")→device.adb("…")(the helper invokesadb, so the leadingadbis dropped). Addeddeviceto the import.runCommand("adb emu sensor set …")→device.adb("emu sensor set …"), plus adeviceimport line.devicemethods (adb,passAudioAsMicrophoneInput) in the same style as the existing entries, and mentioned them in the intro.No remaining
runCommandreferences in the Android docs.Dependency / merge order
These docs reference
device.adb()anddevice.passAudioAsMicrophoneInput(), which ship in platform PR qawolf/platform#27106 (GEN-1953). Hold this until that lands so the docs don't point at APIs that aren't released yet. (Naming note: the audio helper ispassAudioAsMicrophoneInput, notinjectAudio/playAudio— kept distinct from iOSinjectAudioto avoid a type-bundle clash.)Linear: https://linear.app/qawolf/issue/GEN-1950