Skip to content

Respect Options.RawCellValue when caching (fixes #2316)#2317

Merged
xuri merged 3 commits into
qax-os:masterfrom
grmblfrz:2316-cachefix
May 12, 2026
Merged

Respect Options.RawCellValue when caching (fixes #2316)#2317
xuri merged 3 commits into
qax-os:masterfrom
grmblfrz:2316-cachefix

Conversation

@grmblfrz
Copy link
Copy Markdown
Contributor

@grmblfrz grmblfrz commented May 6, 2026

PR Details

Respect Options.RawCellValue in CalcCellValue

Related issue

CalculateCellValue returns cached value regardless of Options.RawCellValue #2316

How Has This Been Tested

Unit test ist provided

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xuri xuri added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 11, 2026
Comment thread calc.go Outdated
@xuri xuri moved this to Features in Excelize v2.11.0 May 11, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.60%. Comparing base (d4466b6) to head (2cd23d7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2317   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files          32       32           
  Lines       26781    26791   +10     
=======================================
+ Hits        26675    26685   +10     
  Misses         55       55           
  Partials       51       51           
Flag Coverage Δ
unittests 99.60% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I've made some changes based on your branch.

@xuri xuri merged commit 4bebb61 into qax-os:master May 12, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Status: Features

Development

Successfully merging this pull request may close these issues.

2 participants