Skip to content

Dependencies/upgrade spring boot#1454

Draft
KochTobi wants to merge 42 commits into
mainfrom
dependencies/upgrade-spring-boot
Draft

Dependencies/upgrade spring boot#1454
KochTobi wants to merge 42 commits into
mainfrom
dependencies/upgrade-spring-boot

Conversation

@KochTobi

Copy link
Copy Markdown
Contributor

Description

Issue and Traceability

Linked Task Issue

  • Closes: #

Requirement IDs Addressed

  • Requirement IDs:

Requirement Update Status

  • Requirements Updated: The corresponding functional/non-functional requirements in docs/requirements.md have been updated to reflect this implementation.
  • Justification Provided: This PR does not change externally observable behavior, so no requirement update is needed. (Provide brief justification below)

Justification (if applicable)

Changes Summary

Modified Areas

  • Domain layer (domain/model/, domain events, aggregates)
  • Application layer (application/ services, use cases)
  • Infrastructure layer (JPA repositories, external integrations, config)
  • UI / Views (views/ components, Vaadin routes)
  • Database schema (sql/, DDL changes)
  • Tests (unit, integration, or Spock specs)
  • Documentation, CI/CD, or build configuration
  • Other (describe):

Behavioral Changes

  • No behavioral changes (internal refactoring, optimization, test addition, etc.)
  • Yes, behavior changes:

Sensitive Changes Requiring Review

  • Database schema changes (sql/complete-schema.sql, table/column DDL)
  • Spring Security configuration (security/, ACL setup, authentication/authorization)
  • FAIR / RO-Crate export format (docs/fair/, RO-Crate builder logic)
  • Artemis messaging topics (JMS topic names, consumer configuration)
  • Requirement file edits (docs/requirements.md)
  • None of the above

Pre-Submission Checklist

  • Issue Linked: PR references a Task issue (see "Linked Task Issue" section above)
  • Requirements Listed: All functional (R) and non-functional (NFR) requirement IDs are listed above
  • No Constraint IDs: No C (constraint) IDs are listed in the Requirement IDs section
  • Behavior vs. Requirements: Requirement update confirmed OR explicit justification provided
  • Code Style: Code follows Google Java Style Guide (run formatter before commit)
  • Tests: New tests added or existing tests updated to cover changes
  • No Secrets: No hardcoded credentials, API keys, passwords, or secrets committed
  • Documentation: Updated relevant docs if the change affects user-facing behavior or public APIs

Notes for Reviewers

KochTobi and others added 30 commits May 27, 2026 15:50
Disables code signing plugin. Needs to be re-enabled when migration is finished.
Replaces the VaadinWebSecurity as it is deprecated.
Avoids Nullpointer
…aces

- UploadFileDisplay: single onFilesChanged(List) method with FileEntry record and ValidationStatus enum
- UploadContentValidator: validate(String fileName, InputStream) returning Optional<String>
- Pre-commit design: single method approach avoids race conditions; validator returns empty Optional on success, error message on failure
…ator

Document interface contracts, method semantics, ChangeType enum,
FileEntry record fields, ValidationStatus lifecycle, and the
caller-closes-stream ownership rule.
This commit removes the validation whithin the upload component. This makes the ContentUploadComponent.java simpler.
Also, the ContentUploadComponent.java now supports uploading multiple files. This can be configured by ContentUploadComponent#setMaxFiles.
Also, the max file size can be provided using the UploadConfiguration.java or in the application.properties. Negative values remove the constraint.
- Replace UploadWithDisplay with ContentUploadComponent
- Add EditSampleUploadDisplayController for validation handling
- Reuse SampleUploadDisplay for file display
- Remove deprecated onUploadSucceeded method
@KochTobi KochTobi force-pushed the dependencies/upgrade-spring-boot branch from 5de42cd to ed7fdf9 Compare June 15, 2026 13:14
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
7.2% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants