Skip to content

Commit 509fa87

Browse files
authored
Make ParallelIndexes as optional so that it can be defaulted to 1 (#238)
1 parent 886b26a commit 509fa87

4 files changed

Lines changed: 3 additions & 4 deletions

File tree

api/v1/qdrantcluster_types.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,8 @@ type GPU struct {
212212
// ParallelIndexes is the number of parallel indexes to run on the GPU.
213213
// +kubebuilder:default=1
214214
// +kubebuilder:validation:Minimum:=1
215-
ParallelIndexes int `json:"parallelIndexes"`
215+
// +optional
216+
ParallelIndexes int `json:"parallelIndexes,omitempty"`
216217
// GroupsCount is the amount of used vulkan "groups" of GPU.
217218
// In other words, how many parallel points can be indexed by GPU.
218219
// Optimal value might depend on the GPU model.

charts/qdrant-kubernetes-api/templates/region-crds/qdrant.io_qdrantclusters.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -425,7 +425,6 @@ spec:
425425
- allowIntegrated
426426
- forceHalfPrecision
427427
- gpuType
428-
- parallelIndexes
429428
type: object
430429
id:
431430
description: Id specifies the unique identifier of the cluster

crds/qdrant.io_qdrantclusters.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,6 @@ spec:
424424
- allowIntegrated
425425
- forceHalfPrecision
426426
- gpuType
427-
- parallelIndexes
428427
type: object
429428
id:
430429
description: Id specifies the unique identifier of the cluster

docs/api.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ _Appears in:_
277277
| `forceHalfPrecision` _boolean_ | ForceHalfPrecision for `f32` values while indexing.<br />`f16` conversion will take place<br />only inside GPU memory and won't affect storage type. | false | |
278278
| `deviceFilter` _string array_ | DeviceFilter for GPU devices by hardware name. Case-insensitive.<br />List of substrings to match against the gpu device name.<br />Example: [- "nvidia"]<br />If not specified, all devices are accepted. | | MinItems: 1 <br />Optional: \{\} <br /> |
279279
| `devices` _string array_ | Devices is a List of explicit GPU devices to use.<br />If host has multiple GPUs, this option allows to select specific devices<br />by their index in the list of found devices.<br />If `deviceFilter` is set, indexes are applied after filtering.<br />If not specified, all devices are accepted. | | MinItems: 1 <br />Optional: \{\} <br /> |
280-
| `parallelIndexes` _integer_ | ParallelIndexes is the number of parallel indexes to run on the GPU. | 1 | Minimum: 1 <br /> |
280+
| `parallelIndexes` _integer_ | ParallelIndexes is the number of parallel indexes to run on the GPU. | 1 | Minimum: 1 <br />Optional: \{\} <br /> |
281281
| `groupsCount` _integer_ | GroupsCount is the amount of used vulkan "groups" of GPU.<br />In other words, how many parallel points can be indexed by GPU.<br />Optimal value might depend on the GPU model.<br />Proportional, but doesn't necessary equal to the physical number of warps.<br />Do not change this value unless you know what you are doing. | | Minimum: 1 <br />Optional: \{\} <br /> |
282282
| `allowIntegrated` _boolean_ | AllowIntegrated specifies whether to allow integrated GPUs to be used. | false | |
283283

0 commit comments

Comments
 (0)