refactor: removed errVerb argument from the modifyUserRoles function, it's too much and a generic error can be returned

Author: Davidonium

internal/cmd/iam/resolve.go

@@ -82,7 +82,7 @@ func resolveRoleIDs(ctx context.Context, client *qcloudapi.Client, accountID str
 // modifyUserRoles calls AssignUserRoles with the given add/delete IDs, then
 // fetches and prints the resulting role list. errVerb is used in the error
 // message ("failed to <errVerb> roles").
-func modifyUserRoles(s *state.State, cmd *cobra.Command, client *qcloudapi.Client, accountID string, user *iamv1.User, addIDs, removeIDs []string, errVerb string) error {
+func modifyUserRoles(s *state.State, cmd *cobra.Command, client *qcloudapi.Client, accountID string, user *iamv1.User, addIDs, removeIDs []string) error {
 	ctx := cmd.Context()
 
 	_, err := client.IAM().AssignUserRoles(ctx, &iamv1.AssignUserRolesRequest{
@@ -92,7 +92,7 @@ func modifyUserRoles(s *state.State, cmd *cobra.Command, client *qcloudapi.Clien
 		RoleIdsToDelete: removeIDs,
 	})
 	if err != nil {
-		return fmt.Errorf("failed to %s roles: %w", errVerb, err)
+		return fmt.Errorf("failed to modify roles: %w", err)
 	}
 
 	rolesResp, err := client.IAM().ListUserRoles(ctx, &iamv1.ListUserRolesRequest{

internal/cmd/iam/user_assign_role.go

@@ -61,7 +61,7 @@ qcloud iam user assign-role user@example.com --role admin,viewer`,
 				return err
 			}
 
-			return modifyUserRoles(s, cmd, client, accountID, user, roleIDs, nil, "assign")
+			return modifyUserRoles(s, cmd, client, accountID, user, roleIDs, nil)
 		},
 	}.CobraCommand(s)
 }

internal/cmd/iam/user_remove_role.go

@@ -58,7 +58,7 @@ qcloud iam user remove-role user@example.com --role admin --role viewer`,
 				return err
 			}
 
-			return modifyUserRoles(s, cmd, client, accountID, user, nil, roleIDs, "remove")
+			return modifyUserRoles(s, cmd, client, accountID, user, nil, roleIDs)
 		},
 	}.CobraCommand(s)
 }