-
Notifications
You must be signed in to change notification settings - Fork 217
Add if_not_exists parameter to create_collection #1149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
veeceey
wants to merge
4
commits into
qdrant:master
Choose a base branch
from
veeceey:fix/issue-1022-create-collection-if-not-exists
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
5383925
Add if_not_exists parameter to create_collection
veeceey 437d667
Add negative test cases for create_collection duplicate behavior
veeceey 5f2a2eb
Refactor tests to use pytest fixtures for reliable cleanup
veeceey 967c346
explicitly pass if_not_exists=False in test cases
veeceey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,124 @@ | ||
| import pytest | ||
| from qdrant_client import QdrantClient, models | ||
| from qdrant_client.async_qdrant_client import AsyncQdrantClient | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def sync_client(): | ||
| client = QdrantClient(":memory:") | ||
| yield client | ||
| client.close() | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| async def async_client(): | ||
| client = AsyncQdrantClient(":memory:") | ||
| yield client | ||
| await client.close() | ||
|
|
||
|
|
||
| def test_create_collection_if_not_exists_sync(sync_client): | ||
| """Test that create_collection with if_not_exists parameter works correctly for sync client""" | ||
| collection_name = "test_collection_if_not_exists" | ||
|
|
||
| # Create collection with if_not_exists=True (collection doesn't exist yet) | ||
| result = sync_client.create_collection( | ||
| collection_name=collection_name, | ||
| vectors_config=models.VectorParams(size=10, distance=models.Distance.COSINE), | ||
| if_not_exists=True, | ||
| ) | ||
| assert result is True | ||
| assert sync_client.collection_exists(collection_name) | ||
|
|
||
| # Try to create again with if_not_exists=True (should not fail, return True) | ||
| result = sync_client.create_collection( | ||
| collection_name=collection_name, | ||
| vectors_config=models.VectorParams(size=10, distance=models.Distance.COSINE), | ||
| if_not_exists=True, | ||
| ) | ||
| assert result is True | ||
|
|
||
|
|
||
| def test_create_collection_if_not_exists_false_sync(sync_client): | ||
| """Test that create_collection with if_not_exists=False still creates collection""" | ||
| collection_name = "test_collection_if_not_exists_false" | ||
|
|
||
| # Create collection with explicit if_not_exists=False | ||
| result = sync_client.create_collection( | ||
| collection_name=collection_name, | ||
| vectors_config=models.VectorParams(size=10, distance=models.Distance.COSINE), | ||
| if_not_exists=False, | ||
| ) | ||
| assert result is True | ||
| assert sync_client.collection_exists(collection_name) | ||
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_create_collection_if_not_exists_async(async_client): | ||
| """Test that create_collection with if_not_exists parameter works correctly for async client""" | ||
| collection_name = "test_collection_if_not_exists_async" | ||
|
|
||
| # Create collection with if_not_exists=True (collection doesn't exist yet) | ||
| result = await async_client.create_collection( | ||
| collection_name=collection_name, | ||
| vectors_config=models.VectorParams(size=10, distance=models.Distance.COSINE), | ||
| if_not_exists=True, | ||
| ) | ||
| assert result is True | ||
| assert await async_client.collection_exists(collection_name) | ||
|
|
||
| # Try to create again with if_not_exists=True (should not fail, return True) | ||
| result = await async_client.create_collection( | ||
| collection_name=collection_name, | ||
| vectors_config=models.VectorParams(size=10, distance=models.Distance.COSINE), | ||
| if_not_exists=True, | ||
| ) | ||
| assert result is True | ||
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_create_collection_if_not_exists_false_async(async_client): | ||
| """Test that create_collection with if_not_exists=False still creates collection""" | ||
| collection_name = "test_collection_if_not_exists_false_async" | ||
|
|
||
| # Create collection with explicit if_not_exists=False | ||
| result = await async_client.create_collection( | ||
| collection_name=collection_name, | ||
| vectors_config=models.VectorParams(size=10, distance=models.Distance.COSINE), | ||
| if_not_exists=False, | ||
| ) | ||
| assert result is True | ||
| assert await async_client.collection_exists(collection_name) | ||
|
|
||
|
|
||
| def test_create_collection_without_if_not_exists_raises_on_duplicate_sync(sync_client): | ||
| """Test that creating an existing collection without if_not_exists=True raises an error.""" | ||
| collection_name = "test_duplicate_error" | ||
|
|
||
| sync_client.create_collection( | ||
| collection_name=collection_name, | ||
| vectors_config=models.VectorParams(size=10, distance=models.Distance.COSINE), | ||
| ) | ||
|
|
||
| with pytest.raises(ValueError, match="already exists"): | ||
| sync_client.create_collection( | ||
| collection_name=collection_name, | ||
| vectors_config=models.VectorParams(size=10, distance=models.Distance.COSINE), | ||
| ) | ||
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_create_collection_without_if_not_exists_raises_on_duplicate_async(async_client): | ||
| """Test that creating an existing collection without if_not_exists=True raises an error (async).""" | ||
| collection_name = "test_duplicate_error_async" | ||
|
|
||
| await async_client.create_collection( | ||
| collection_name=collection_name, | ||
| vectors_config=models.VectorParams(size=10, distance=models.Distance.COSINE), | ||
| ) | ||
|
|
||
| with pytest.raises(ValueError, match="already exists"): | ||
| await async_client.create_collection( | ||
| collection_name=collection_name, | ||
| vectors_config=models.VectorParams(size=10, distance=models.Distance.COSINE), | ||
| ) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.