Skip to content

Commit bd8d61b

Browse files
authored
Fix [BREAKING]: ClusterConfiguration.reserved_* fields should be optional (#261)
The default is 20%, not 0% and the alowed values are 1..80 BREAKING ``` proto/qdrant/cloud/cluster/v1/cluster.proto:616:3:Field "20" with name "reserved_cpu_percentage" on message "ClusterConfiguration" changed cardinality from "optional with implicit presence" to "optional with explicit presence". proto/qdrant/cloud/cluster/v1/cluster.proto:623:3:Field "21" with name "reserved_memory_percentage" on message "ClusterConfiguration" changed cardinality from "optional with implicit presence" to "optional with explicit presence". ⚠️ Warning: Breaking changes detected! These should generally be avoided. Continuing with code generation... ```
1 parent 5b4bf72 commit bd8d61b

7 files changed

Lines changed: 117 additions & 109 deletions

File tree

gen/go/qdrant/cloud/cluster/v1/cluster.pb.go

Lines changed: 20 additions & 18 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/openapiv2/qdrant/cloud/cluster/backup/v1/backup.swagger.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/openapiv2/qdrant/cloud/cluster/v1/cluster.swagger.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/python/qdrant/cloud/cluster/v1/cluster_pb2.py

Lines changed: 64 additions & 64 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/typescript/qdrant/cloud/cluster/v1/cluster_pb.d.ts

Lines changed: 16 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/typescript/qdrant/cloud/cluster/v1/cluster_pb.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

proto/qdrant/cloud/cluster/v1/cluster.proto

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -611,13 +611,19 @@ message ClusterConfiguration {
611611
// It is ignored for managed cloud clusters. This is an optional field
612612
repeated common.v1.KeyValue pod_labels = 14 [(buf.validate.field).repeated = {max_items: 10}];
613613
// The percentage of CPU resources reserved for system components
614-
// This is an optional field, default is 0.
615-
// Number between 0..80
616-
uint32 reserved_cpu_percentage = 20 [(buf.validate.field).uint32 = {lte: 80}];
614+
// This is an optional field, default is 20%.
615+
// Number between 1..80 (both included)
616+
optional uint32 reserved_cpu_percentage = 20 [(buf.validate.field).uint32 = {
617+
gte: 1
618+
lte: 80
619+
}];
617620
// The percentage of RAM resources reserved for system components
618-
// This is an optional field, default is 0.
619-
// Number between 0..80
620-
uint32 reserved_memory_percentage = 21 [(buf.validate.field).uint32 = {lte: 80}];
621+
// This is an optional field, default is 20%.
622+
// Number between 1..80 (both included)
623+
optional uint32 reserved_memory_percentage = 21 [(buf.validate.field).uint32 = {
624+
gte: 1
625+
lte: 80
626+
}];
621627
// The gpu type that should be used for the database
622628
// This is an optional field, default is No configured GPU
623629
optional ClusterConfigurationGpuType gpu_type = 22 [(buf.validate.field).enum = {

0 commit comments

Comments
 (0)