Skip to content

Commit c2a74f2

Browse files
authored
[BREAKING] Resolved todo (#153)
This will cleanup the TODO, found in previous review of the complete API, which was non breaking only.
1 parent 0ec8d1d commit c2a74f2

7 files changed

Lines changed: 24 additions & 91 deletions

File tree

gen/go/qdrant/cloud/serverless/collection/auth/v1/collection_api_key.pb.go

Lines changed: 4 additions & 27 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/openapiv2/qdrant/cloud/serverless/collection/auth/v1/collection_api_key.swagger.json

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -153,14 +153,6 @@
153153
"CollectionApiKeyServiceCreateCollectionApiKeyBody": {
154154
"type": "object",
155155
"properties": {
156-
"accountId": {
157-
"type": "string",
158-
"description": "The identifier of the account (in GUID format).\nThis is a required field.\n\nTODO: Remove! However this is a breaking change, so will be done in separate PR"
159-
},
160-
"collectionId": {
161-
"type": "string",
162-
"description": "Collection the key will access (in GUID format).\nThis is a required field.\n\nTODO: Remove!"
163-
},
164156
"collectionApiKey": {
165157
"type": "object",
166158
"properties": {
@@ -199,7 +191,7 @@
199191
"description": "The key for the collection api key.\nThis is a read-only field and will be available only once in the response of CreateCollectionApiKey.\nYou should securely store this key and it should be handled as a secret."
200192
}
201193
},
202-
"description": "TODO: Renumber to 1",
194+
"description": "The API key to create.\nThis is a required field.",
203195
"title": "The API key to create.\nThis is a required field."
204196
}
205197
},

gen/python/qdrant/cloud/serverless/collection/auth/v1/collection_api_key_pb2.py

Lines changed: 14 additions & 18 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/python/qdrant/cloud/serverless/collection/auth/v1/collection_api_key_pb2.pyi

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,14 +37,10 @@ class ListCollectionApiKeysResponse(_message.Message):
3737
def __init__(self, items: _Optional[_Iterable[_Union[CollectionApiKey, _Mapping]]] = ...) -> None: ...
3838

3939
class CreateCollectionApiKeyRequest(_message.Message):
40-
__slots__ = ("account_id", "collection_id", "collection_api_key")
41-
ACCOUNT_ID_FIELD_NUMBER: _ClassVar[int]
42-
COLLECTION_ID_FIELD_NUMBER: _ClassVar[int]
40+
__slots__ = ("collection_api_key",)
4341
COLLECTION_API_KEY_FIELD_NUMBER: _ClassVar[int]
44-
account_id: str
45-
collection_id: str
4642
collection_api_key: CollectionApiKey
47-
def __init__(self, account_id: _Optional[str] = ..., collection_id: _Optional[str] = ..., collection_api_key: _Optional[_Union[CollectionApiKey, _Mapping]] = ...) -> None: ...
43+
def __init__(self, collection_api_key: _Optional[_Union[CollectionApiKey, _Mapping]] = ...) -> None: ...
4844

4945
class CreateCollectionApiKeyResponse(_message.Message):
5046
__slots__ = ("collection_api_key",)

0 commit comments

Comments
 (0)