Skip to content

Commit ecfd8c4

Browse files
authored
Fix: fields in DatabaseConfigurationCollection should be optional (#248)
``` proto/qdrant/cloud/cluster/v1/cluster.proto:696:3:Field "2" with name "write_consistency_factor" on message "DatabaseConfigurationCollection" changed cardinality from "optional with implicit presence" to "optional with explicit presence". ⚠️ Warning: Breaking changes detected! These should generally be avoided. Continuing with code generation...```
1 parent 376b493 commit ecfd8c4

7 files changed

Lines changed: 78 additions & 104 deletions

File tree

gen/go/qdrant/cloud/cluster/v1/cluster.pb.go

Lines changed: 10 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/openapiv2/qdrant/cloud/cluster/backup/v1/backup.swagger.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/openapiv2/qdrant/cloud/cluster/v1/cluster.swagger.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/python/qdrant/cloud/cluster/v1/cluster_pb2.py

Lines changed: 58 additions & 60 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/typescript/qdrant/cloud/cluster/v1/cluster_pb.d.ts

Lines changed: 4 additions & 31 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/typescript/qdrant/cloud/cluster/v1/cluster_pb.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

proto/qdrant/cloud/cluster/v1/cluster.proto

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -693,9 +693,10 @@ message DatabaseConfigurationCollection {
693693
optional uint32 replication_factor = 1 [(buf.validate.field).uint32.gte = 1];
694694
// How many replicas should apply the operation for us to consider it successful
695695
// This is an optional, the default is 1
696-
int32 write_consistency_factor = 2 [(buf.validate.field).int32.gte = 1];
696+
optional int32 write_consistency_factor = 2 [(buf.validate.field).int32.gte = 1];
697697
// The default parameters for vectors.
698-
DatabaseConfigurationCollectionVectors vectors = 3 [(buf.validate.field).required = true];
698+
// This is an implicit optional field, see DatabaseConfigurationCollectionVectors for defaults.
699+
DatabaseConfigurationCollectionVectors vectors = 3;
699700
}
700701

701702
// The default Qdrant database collection vectors configuration

0 commit comments

Comments
 (0)