Skip to content

[CP-141] Added accounts functions.#100

Merged
Robert-Stam merged 7 commits into
mainfrom
enh/roberts/account-api
Jun 6, 2025
Merged

[CP-141] Added accounts functions.#100
Robert-Stam merged 7 commits into
mainfrom
enh/roberts/account-api

Conversation

@Robert-Stam
Copy link
Copy Markdown
Contributor

@Robert-Stam Robert-Stam commented Jun 5, 2025

This PR only adds the CRUD for account.

Note: The ticket mentions a function: Remove Account Privileges, I doubt this should be public.

This PR only adds the CRUD for account, the next will add Account Privileges (if really needed).
See TODOs in the code, these needs to be resolved in this PR.
@Robert-Stam Robert-Stam self-assigned this Jun 5, 2025
@Robert-Stam Robert-Stam requested a review from a team as a code owner June 5, 2025 12:16
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2025

The latest Buf updates on your PR. Results from workflow Pull Request / linting (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJun 6, 2025, 8:44 AM

@qdrant qdrant deleted a comment from github-actions Bot Jun 5, 2025
Comment thread proto/qdrant/cloud/account/v1/account.proto Outdated
Comment thread proto/qdrant/cloud/account/v1/account.proto Outdated
Comment thread proto/qdrant/cloud/account/v1/account.proto Outdated
Comment thread proto/qdrant/cloud/account/v1/account.proto Outdated
Comment thread proto/qdrant/cloud/account/v1/account.proto Outdated
Comment thread proto/qdrant/cloud/account/v1/account.proto
Copy link
Copy Markdown
Contributor

@mikheillomidzeq mikheillomidzeq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Robert!

Left some comments

Comment thread proto/qdrant/cloud/account/v1/account.proto
Comment thread proto/qdrant/cloud/account/v1/account.proto
Comment thread proto/qdrant/cloud/account/v1/account.proto Outdated
Comment thread proto/qdrant/cloud/account/v1/account.proto Outdated
Co-authored-by: Toni Reina <toni.reina@qdrant.com>
github-actions[bot]

This comment was marked as resolved.

Copy link
Copy Markdown
Contributor

@mikheillomidzeq mikheillomidzeq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread proto/qdrant/cloud/account/v1/account.proto Outdated
@areina
Copy link
Copy Markdown

areina commented Jun 6, 2025

Aboout the Remove Account Privileges endpoint, we don't need it.

@Robert-Stam Robert-Stam merged commit f29083f into main Jun 6, 2025
14 checks passed
@Robert-Stam Robert-Stam deleted the enh/roberts/account-api branch June 6, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants