Update AccountService#110
Merged
Merged
Conversation
Update it with few changes to represent the existing implementation.
|
The latest Buf updates on your PR. Results from workflow Pull Request / linting (pull_request).
|
Author
|
This PR contains breaking changes but they are acceptable because this API isn't used yet. |
Robert-Stam
approved these changes
Jun 18, 2025
Contributor
Robert-Stam
left a comment
Robert-Stam
left a comment
There was a problem hiding this comment.
LGTM, From an API PoV we should imo add the removed field later-on back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update it with few changes to represent the existing implementation.