Add the supported_actor_types option to several APIs#112
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Pull Request / linting (pull_request).
|
- Update `AccountService` adding that option in several methods. - Update `IAMService` adding that option in several methods. - Update method comments trying to consolidate the style.
areina
force-pushed
the
chore/toni/add-supported-actor-types
branch
from
553c8c2 to
68dfc1e
Compare
Robert-Stam
approved these changes
Jun 20, 2025
Author
You're right, I updated them thinking only on this file. Let me update this PR changing them to the third-person singular form and later I will open a new PR reviewing all the other APIs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AccountServiceadding that option in several methods.IAMServiceadding that option in several methods.