Add is_owner and is_default to the Account message as read-only fields#114
Closed
Rendez wants to merge 1 commit into
Closed
Add is_owner and is_default to the Account message as read-only fields#114Rendez wants to merge 1 commit into
Rendez wants to merge 1 commit into
Conversation
|
The latest Buf updates on your PR. Results from workflow Pull Request / linting (pull_request).
|
Robert-Stam
reviewed
Jun 20, 2025
Comment on lines
+421
to
+422
| // This field is read-only and is set by the server based on the authenticated user. | ||
| // It indicates whether the authenticated user is the owner of the account. |
Contributor
There was a problem hiding this comment.
please switch order of lines (on all places we mention read-only / required) not to start with...
Robert-Stam
reviewed
Jun 20, 2025
Comment on lines
+424
to
+425
| // This field is read-only and is set by the server based on the authenticated user. | ||
| // It indicates whether the account is the default account for the authenticated user. |
Contributor
There was a problem hiding this comment.
please switch order of lines (on all places we mention read-only / required) not to start with...
Contributor
Author
|
After discussing with @areina , I am dropping my PR, and sadly we already added In the end, it was all about an agreement on how to massage data on our end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: https://qdrant.atlassian.net/browse/CF-980
Instead of checking for owner_email against user.email all the time, which is sort of cumbersome, let’s add a is_owner bool, much like
is_defaultis there for the same purpose.