Skip to content

BIl-116 Add ListPrepaidCredits RPC to BillingService#343

Merged
nzerouali merged 9 commits intomainfrom
bil-116-prepaid-credits-grpc-api
Apr 16, 2026
Merged

BIl-116 Add ListPrepaidCredits RPC to BillingService#343
nzerouali merged 9 commits intomainfrom
bil-116-prepaid-credits-grpc-api

Conversation

@nzerouali
Copy link
Copy Markdown
Contributor

@nzerouali nzerouali commented Apr 16, 2026

Ticket: BIl-116
Adds a new RPC to the BillingService to list prepaid credit contracts for an organization.

  • New ListCreditContracts RPC, scoped by account_id
  • New CreditContract message with fields: id, account_id, total_amount_usd, billing_frequency, active_from, active_to, notes
  • REST endpoint: GET /api/billing/v1/accounts/{account_id}/credit-contracts

@nzerouali nzerouali requested a review from a team as a code owner April 16, 2026 09:04
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 16, 2026

PR Packages Published

Python Package:

  • Version: 0.116.0.dev343+4444461
  • Package: qdrant-cloud-public-api
  • Registry: https://us-python.pkg.dev/qdrant-cloud/python/
  • To update run: uv add qdrant-cloud-public-api==0.116.0.dev343+4444461

NPM Package:

  • Version: 0.116.0-dev343.4444461
  • Package: @qdrant/qdrant-cloud-public-api
  • Registry: https://us-npm.pkg.dev/qdrant-cloud/npm/
  • To update run: npm install @qdrant/qdrant-cloud-public-api@0.116.0-dev343.4444461

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 16, 2026

The latest Buf updates on your PR. Results from workflow Pull Request / linting (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedApr 16, 2026, 12:42 PM

Comment thread proto/qdrant/cloud/billing/v1/billing.proto Outdated
Comment thread proto/qdrant/cloud/billing/v1/billing.proto Outdated
Comment thread proto/qdrant/cloud/billing/v1/billing.proto Outdated
Comment thread proto/qdrant/cloud/billing/v1/billing.proto Outdated
Comment thread proto/qdrant/cloud/billing/v1/billing.proto
@nzerouali nzerouali requested a review from StefosGeo April 16, 2026 10:41
Copy link
Copy Markdown
Contributor

@lomidzemikheili lomidzemikheili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

organization_id confuses me, why we use it and in the end we treat it like an account_id.

If there is not intention behind it, I would stick with account_id.

@nzerouali
Copy link
Copy Markdown
Contributor Author

organization_id confuses me, why we use it and in the end we treat it like an account_id.

If there is not intention behind it, I would stick with account_id.

@lomidzemikheili organization_id here is intentional. It refers to the parent account, not any other individual account. In our hierarchy, an organization can have multiple accounts under it, and prepaid credits are signed at the organization level, covering all its child accounts. Using account_id would be misleading and imply the contract is scoped to a single account.

github-actions[bot]

This comment was marked as resolved.

Copy link
Copy Markdown
Contributor

@lomidzemikheili lomidzemikheili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for addressing my feedback.

@nzerouali nzerouali merged commit 0ca9cfd into main Apr 16, 2026
14 checks passed
@nzerouali nzerouali deleted the bil-116-prepaid-credits-grpc-api branch April 16, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants