Add ListCreditContractConsumptions RPC#344
Merged
Conversation
|
PR Packages Published Python Package:
NPM Package:
|
|
The latest Buf updates on your PR. Results from workflow Pull Request / linting (pull_request).
|
This comment has been minimized.
This comment has been minimized.
StefosGeo
approved these changes
Apr 16, 2026
Contributor
StefosGeo
left a comment
StefosGeo
left a comment
There was a problem hiding this comment.
Looks good , my only comment would be if we need both used_amount and remaining_amount, but I don't have a strong opinion so I approve
lomidzemikheili
approved these changes
Apr 16, 2026
Contributor
lomidzemikheili
left a comment
lomidzemikheili
left a comment
There was a problem hiding this comment.
LGTM! Thanks.
Left one minor comment.
lomidzemikheili
approved these changes
Apr 16, 2026
Contributor
lomidzemikheili
left a comment
lomidzemikheili
left a comment
There was a problem hiding this comment.
Thanks for addressing feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: BIl-117
Follow-uo PR to add a new RPC to list consumption data for credit contracts.
ListCreditContractConsumptionsRPC, scoped byaccount_idCreditContractConsumptionmessage withcredit_contract_id,total_amount,used_amount,remaining_amount,currency