Add billing account hierarchy endpoints (parent+children)#348
Merged
Add billing account hierarchy endpoints (parent+children)#348
Conversation
|
The latest Buf updates on your PR. Results from workflow Pull Request / linting (pull_request).
|
|
PR Packages Published Python Package:
NPM Package:
|
StefosGeo
reviewed
Apr 22, 2026
Contributor
StefosGeo
left a comment
There was a problem hiding this comment.
As mentioned below in the comments, we might want to think about this API a bit more abstract. The GetBillingAccountStatusResponse looks a bit multi purposed. IMO the solution of having a /parent endpoint that returns the parent-id or null/404 if the current account is parent , would be cleaner.
What is your opinion ?
baranbartu
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: BIL-128
Adds two new endpoints to
BillingServiceto expose an account's position in the billing hierarchy:GET /api/billing/v1/accounts/{account_id}/parent: returns the parent account ID; NOT_FOUND if the account has no parent (standalone or root)GET /api/billing/v1/accounts/{account_id}/children: returns the list of child account IDs; empty list if the account has no children.These endpoints are needed for the Usage Breakdown UI, where a parent needs to enumerate its child accounts and a child account needs to know its parent.