Skip to content

Add billing account hierarchy endpoints (parent+children)#348

Merged
nzerouali merged 3 commits intomainfrom
bil-128-billing-account-status
Apr 22, 2026
Merged

Add billing account hierarchy endpoints (parent+children)#348
nzerouali merged 3 commits intomainfrom
bil-128-billing-account-status

Conversation

@nzerouali
Copy link
Copy Markdown
Contributor

@nzerouali nzerouali commented Apr 21, 2026

Ticket: BIL-128

Adds two new endpoints to BillingService to expose an account's position in the billing hierarchy:

  • GET /api/billing/v1/accounts/{account_id}/parent: returns the parent account ID; NOT_FOUND if the account has no parent (standalone or root)
  • GET /api/billing/v1/accounts/{account_id}/children: returns the list of child account IDs; empty list if the account has no children.

These endpoints are needed for the Usage Breakdown UI, where a parent needs to enumerate its child accounts and a child account needs to know its parent.

@nzerouali nzerouali requested a review from a team as a code owner April 21, 2026 15:47
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

The latest Buf updates on your PR. Results from workflow Pull Request / linting (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedApr 22, 2026, 9:13 AM

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

PR Packages Published

Python Package:

  • Version: 0.118.0.dev348+6d80b17
  • Package: qdrant-cloud-public-api
  • Registry: https://us-python.pkg.dev/qdrant-cloud/python/
  • To update run: uv add qdrant-cloud-public-api==0.118.0.dev348+6d80b17

NPM Package:

  • Version: 0.118.0-dev348.6d80b17
  • Package: @qdrant/qdrant-cloud-public-api
  • Registry: https://us-npm.pkg.dev/qdrant-cloud/npm/
  • To update run: npm install @qdrant/qdrant-cloud-public-api@0.118.0-dev348.6d80b17

Copy link
Copy Markdown
Contributor

@StefosGeo StefosGeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned below in the comments, we might want to think about this API a bit more abstract. The GetBillingAccountStatusResponse looks a bit multi purposed. IMO the solution of having a /parent endpoint that returns the parent-id or null/404 if the current account is parent , would be cleaner.
What is your opinion ?

Comment thread proto/qdrant/cloud/billing/v1/billing.proto Outdated
Comment thread proto/qdrant/cloud/billing/v1/billing.proto Outdated
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the PR doesn't include updates for the generated code.

Please make sure you've run the following commands from the root directory:

make generate

Once you've added them, you can dismiss this review.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the PR doesn't include updates for the generated code.

Please make sure you've run the following commands from the root directory:

make generate

Once you've added them, you can dismiss this review.

@nzerouali nzerouali changed the title Add GetBillingAccountStatus RPC to BillingService Add billing account hierarchy endpoints (parent+children) Apr 22, 2026
@nzerouali nzerouali requested a review from StefosGeo April 22, 2026 09:16
Copy link
Copy Markdown
Contributor

@StefosGeo StefosGeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nzerouali nzerouali merged commit 5d7e445 into main Apr 22, 2026
16 checks passed
@nzerouali nzerouali deleted the bil-128-billing-account-status branch April 22, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants