Add scalability_info field to ClusterState#84
Conversation
|
@Rendez I think you were the original author of the Additionally, we would prefer to take a more extensible approach, adding a |
|
The latest Buf updates on your PR. Results from workflow Pull Request / linting (pull_request).
|
Add a field which indicates whether the cluster can be scaled up or down.
areina
force-pushed
the
feat/toni/add-scalable-field-to-cluster
branch
from
a24ba0f to
03cf38e
Compare
|
I had a discussion with @Rendez the other day, and the main reason to have a specific endpoint to retrieve this information was that the existing endpoint used to retrieve the cluster is expensive to compute and includes more fields than the necessary. I believe we can address both of these issues in the new api, and it's better to include this information as a field of the cluster rather than expose it through a separate method. I've updated the PR accordingly. |
areina
changed the title
scalable field to ClusterStatescalability_info field to ClusterState
| // ClusterScalabilityInfo provides information about the | ||
| message ClusterScalabilityInfo { | ||
| // The current scalability status of the cluster. | ||
| ClusterScalabilityStatus status = 1; |
There was a problem hiding this comment.
I don't see how we can e.g.
- make it possible to scale up, but not down
- make it possible to scale up to e.g. 16 nodes
- to scale down a 10 cluster to 8 (not smaller).
2 participants
Add a field that indicates whether the cluster can be scaled up or down.
Instead of using a boolean field, which isn't extensible, we're adding a new message to represent information about the scalability of the cluster. At this moment the message contains the status and the reason for that status.