Add MonitoringService API#96
Conversation
This comment has been minimized.
This comment has been minimized.
|
The latest Buf updates on your PR. Results from workflow Pull Request / linting (pull_request).
|
areina
force-pushed
the
feat/toni/add-monitoring-service
branch
from
51e5022 to
15ca46b
Compare
| optional google.protobuf.Timestamp until = 4; | ||
| // Aggregation function to apply to the time series data. | ||
| // If omitted, defaults to SUM. | ||
| optional Aggregator aggregator = 5; |
There was a problem hiding this comment.
should we specify a resolution, or is this automatically inferred by the span (aka duration)?
There was a problem hiding this comment.
Step is automatically chosen depending on the metric and the span
|
|
||
| // IntervalAverage represents the average value of a metric over a specific time interval. | ||
| message IntervalAverage { | ||
| // TODO which unit do they represent? minutes? Also, can we change them to int? |
There was a problem hiding this comment.
what about google.protobuf.Duration, so we can do 5min resolution ?
Shouldn't we add this to the request and only provide a single result?
There was a problem hiding this comment.
I think google.protobuf.Duration makes sense. Currently the response is always including 4 intervals, looking at the code it seems they are (current value, last hour, last 3 hours, last 24 hours).
I guess for current we could set a Duration of 0.
About changing the request and returning only a single result, I think that would require more changes in the UI and not sure if it's worth the investment at this moment. However, I'm open to discuss it.
areina
force-pushed
the
feat/toni/add-monitoring-service
branch
from
15ca46b to
78cd122
Compare
3 participants
No description provided.