[CP-142] Add ListGlobalPackages service definition#97
Merged
mikheillomidzeq merged 12 commits intoJun 4, 2025
Conversation
|
The latest Buf updates on your PR. Results from workflow Pull Request / linting (pull_request).
|
mikheillomidzeq
commented
May 30, 2025
Robert-Stam
reviewed
May 30, 2025
Robert-Stam
reviewed
May 30, 2025
Robert-Stam
reviewed
May 30, 2025
Robert-Stam
reviewed
May 30, 2025
| // permissions | ||
| option (common.v1.permissions) = ""; | ||
| // gRPC Gateway REST call | ||
| option (google.api.http) = {get: "/api/public/v1/packages"}; |
Contributor
There was a problem hiding this comment.
this isn't the intended way of creating URLs, but this is related to the fact a new Service got introduced
Contributor
Author
There was a problem hiding this comment.
I changed the url, please take a look if it looks okay now.
Robert-Stam
reviewed
May 30, 2025
Robert-Stam
reviewed
May 30, 2025
Robert-Stam
reviewed
May 30, 2025
This comment has been minimized.
This comment has been minimized.
areina
suggested changes
Jun 2, 2025
Robert-Stam
reviewed
Jun 2, 2025
Robert-Stam
reviewed
Jun 2, 2025
Robert-Stam
reviewed
Jun 2, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Robert-Stam
reviewed
Jun 3, 2025
Robert-Stam
reviewed
Jun 3, 2025
mikheillomidzeq
changed the title
areina
approved these changes
Jun 3, 2025
…-api # Conflicts: # .github/actions/spelling/allow.txt
areina
approved these changes
Jun 4, 2025
mikheillomidzeq
deleted the
feature/mikheil/publicly-accessible-packages-api
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to: https://qdrant.atlassian.net/browse/CP-142