feat: add additionalInitContainers support to Qdrant StatefulSet#481
Open
naveenkumarsp wants to merge 1 commit into
Open
feat: add additionalInitContainers support to Qdrant StatefulSet#481naveenkumarsp wants to merge 1 commit into
naveenkumarsp wants to merge 1 commit into
Conversation
The chart currently has no hook for injecting custom init containers. Init containers run sequentially to completion before the main Qdrant container starts, which is the correct place for one-shot node-level setup (e.g. raising vm.max_map_count before Qdrant loads collections). Without this, operators must either: - Add a privileged sidecar that runs sysctl alongside Qdrant (no strict ordering guarantee, container must sleep forever to stay alive), or - Deploy a separate DaemonSet tied to specific node pool labels. Changes: - templates/statefulset.yaml: append .Values.additionalInitContainers after the existing ensure-dir-ownership init container block. - values.yaml: add additionalInitContainers: [] with a fully commented real-world example (vm.max_map_count) and guidance on when to prefer init containers over sidecarContainers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The chart provides no hook for custom init containers. Operators needing
one-shot node-level setup before Qdrant starts (e.g. raising
vm.max_map_countto avoidENOMEMon mmap-heavy deployments with manycollections and shards) are forced to use workarounds:
sleep infinityto stay alive alongside Qdrant.
node pool label coordination.
Solution
Add
additionalInitContainerstovalues.yaml(default[]). Entriesare appended after the existing
ensure-dir-ownershipinit container inthe StatefulSet template, so they run sequentially before Qdrant starts.
Changes
templates/statefulset.yaml— renderadditionalInitContainersafterthe
ensure-dir-ownershipblock.values.yaml— addadditionalInitContainers: []with a fullycommented real-world example (
vm.max_map_count) and guidance on whento prefer init containers over
sidecarContainers.Example usage