Skip to content

Commit b283825

Browse files
committed
WIP: refactor
1 parent 80709bb commit b283825

3 files changed

Lines changed: 18 additions & 6 deletions

File tree

.github/workflows/continuous-benchmark-transfer.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ on:
88
default: 'laion-small-clip'
99
type: string
1010
qdrant_versions:
11-
description: 'Comma-separated versions to compare (ghcr/dev, docker/master, docker/v1.13.0)'
11+
description: 'Comma-separated versions to compare (ghcr/dev, docker/master, docker/v1.13.0). Can be just single version.'
1212
default: 'ghcr/dev,docker/v1.16.3'
1313
type: string
1414
region:

ansible/playbooks/roles/run-transfer-speed/files/shard_transfer.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,15 +81,18 @@ def storage_types(self, uri: str) -> dict:
8181
return {}
8282

8383
def wait_mmap(self, uri: str, timeout=180):
84+
print(f"Waiting for Mmap segments...")
8485
start = time.time()
86+
types = {}
8587
while time.time() - start < timeout:
8688
types = self.storage_types(uri)
8789
mmap = types.get("Mmap", 0)
8890
chunked = types.get("ChunkedMmap", 0) + types.get("InRamChunkedMmap", 0)
91+
print(f" Storage types: {types}")
8992
if mmap > 0 and mmap >= chunked:
9093
return
91-
time.sleep(2)
92-
raise TimeoutError("Mmap segments timeout")
94+
time.sleep(5)
95+
print(f"Warning: Mmap timeout, continuing anyway. Types: {types}")
9396

9497
def wait_transfer(self, timeout=600):
9598
start = time.time()

ansible/playbooks/roles/run-transfer-speed/tasks/main.yml

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
11
---
2+
- name: Install python3-venv
3+
ansible.builtin.package:
4+
name: python3-venv
5+
state: present
6+
27
- name: Setup
38
ansible.builtin.shell: mkdir -p {{ working_dir }}/data/{{ dataset_name }}
49
args:
@@ -18,19 +23,23 @@
1823
- {src: "run-bench.sh", dest: "{{ working_dir }}/run-bench.sh", mode: '0755'}
1924
- {src: "{{ playbook_dir }}/files/transfer-speed/requirements.txt", dest: "{{ working_dir }}/requirements.txt"}
2025

26+
- name: Check dataset
27+
stat:
28+
path: "{{ working_dir }}/data/{{ dataset_name }}/vectors.npy"
29+
register: vectors_file
30+
2131
- name: Download dataset
2232
ansible.builtin.get_url:
2333
url: "{{ dataset.link }}"
2434
dest: "{{ working_dir }}/data/{{ dataset_name }}.tgz"
25-
args:
26-
creates: "{{ working_dir }}/data/{{ dataset_name }}.tgz"
35+
when: not vectors_file.stat.exists
2736

2837
- name: Extract dataset
2938
ansible.builtin.unarchive:
3039
src: "{{ working_dir }}/data/{{ dataset_name }}.tgz"
3140
dest: "{{ working_dir }}/data/{{ dataset_name }}"
3241
remote_src: yes
33-
creates: "{{ working_dir }}/data/{{ dataset_name }}/vectors.npy"
42+
when: not vectors_file.stat.exists
3443

3544
- name: Run benchmark
3645
ansible.builtin.shell: "{{ working_dir }}/run-bench.sh"

0 commit comments

Comments
 (0)