Skip to content

Commit 5e0bca4

Browse files
silverdevJesseLovelace
authored andcommitted
Added explicit decencies for surefile-junit4 in order to fix testing in offline mode. (googleapis#3820)
* Added explicit sunfire-junit depency to pull it in for offline mode. Without this dependency explicitly listed java mvn dependency:go-offline will not pull it in and mvn -o verify will not work (Unless the tests have been run in online mode. In this case the cached surefire junit can still be used.) * Adding Surefire depency to bigtable admin and logging as well. * Looks like I need to tell the plugin that it's using the version I'm pulling in. * Looks like the Google Cloud Java Compatibility Checker test require surefire version 2.17 [INFO] Building Google Cloud Java Compatibility Checker 0.67.1-alpha-SNAPSHOT [INFO] ------------------------------------------------------------------------ [WARNING] The POM for org.apache.maven.plugins:maven-surefire-plugin:jar:2.17 is missing, no dependency information available * dependecies is not under build. * Some of the GRPC library need dependencies need surefire 2.17 [INFO] ------------------------------------------------------------------------ [INFO] Building Google Cloud API gRPC 0.32.1-SNAPSHOT [INFO] ------------------------------------------------------------------------ [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Building proto-google-cloud-asset-v1beta1 0.32.1-SNAPSHOT [INFO] ------------------------------------------------------------------------ [WARNING] The POM for org.apache.maven.plugins:maven-surefire-plugin:jar:2.17 is missing, no dependency information available [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Skipping grpc-google-cloud-asset-v1beta1 [INFO] This project has been banned from the build due to previous failures. [INFO] ------------------------------------------------------------------------ [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Building proto-google-cloud-automl-v1beta1 0.32.1-SNAPSHOT [INFO] ------------------------------------------------------------------------ [WARNING] The POM for org.apache.maven.plugins:maven-surefire-plugin:jar:2.17 is missing, no dependency information available [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Skipping grpc-google-cloud-automl-v1beta1 [INFO] This project has been banned from the build due to previous failures. [INFO] ------------------------------------------------------------------------ * Looks like the file path is org.apache.maven.plugins * lets try putting the in utils. It looks like utill uses surefire 2.17 * Looks like spanner uses surefire-junit47 instead of surefire-junit4 * Re-add bigtable admin version * Lets not include spanner with this PR.
1 parent 1bc5fcf commit 5e0bca4

File tree

4 files changed

+42
-0
lines changed

4 files changed

+42
-0
lines changed

google-cloud-clients/google-cloud-bigtable-admin/pom.xml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,11 @@
9393
<artifactId>grpc-testing</artifactId>
9494
<scope>test</scope>
9595
</dependency>
96+
<dependency>
97+
<groupId>org.apache.maven.surefire</groupId>
98+
<artifactId>surefire-junit4</artifactId>
99+
<version>2.19.1</version>
100+
</dependency>
96101
</dependencies>
97102
<profiles>
98103
<profile>
@@ -125,6 +130,13 @@
125130
<perCoreThreadCount>true</perCoreThreadCount>
126131
<threadCount>2</threadCount>
127132
</configuration>
133+
<dependencies>
134+
<dependency>
135+
<groupId>org.apache.maven.surefire</groupId>
136+
<artifactId>surefire-junit4</artifactId>
137+
<version>2.19.1</version>
138+
</dependency>
139+
</dependencies>
128140
</plugin>
129141
</plugins>
130142
</build>

google-cloud-clients/google-cloud-bigtable/pom.xml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,11 @@
9696
<artifactId>grpc-testing</artifactId>
9797
<scope>test</scope>
9898
</dependency>
99+
<dependency>
100+
<groupId>org.apache.maven.surefire</groupId>
101+
<artifactId>surefire-junit4</artifactId>
102+
<version>2.19.1</version>
103+
</dependency>
99104
</dependencies>
100105
<profiles>
101106
<profile>
@@ -128,6 +133,13 @@
128133
<perCoreThreadCount>true</perCoreThreadCount>
129134
<threadCount>2</threadCount>
130135
</configuration>
136+
<dependencies>
137+
<dependency>
138+
<groupId>org.apache.maven.surefire</groupId>
139+
<artifactId>surefire-junit4</artifactId>
140+
<version>2.19.1</version>
141+
</dependency>
142+
</dependencies>
131143
</plugin>
132144
</plugins>
133145
</build>

google-cloud-clients/google-cloud-logging/pom.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,5 +88,10 @@
8888
<classifier>testlib</classifier>
8989
<scope>test</scope>
9090
</dependency>
91+
<dependency>
92+
<groupId>org.apache.maven.surefire</groupId>
93+
<artifactId>surefire-junit4</artifactId>
94+
<version>2.19.1</version>
95+
</dependency>
9196
</dependencies>
9297
</project>

google-cloud-util/pom.xml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,19 @@
1313
<modules>
1414
<module>google-cloud-compat-checker</module>
1515
</modules>
16+
<dependencies>
17+
<dependency>
18+
<groupId>org.apache.maven.plugins</groupId>
19+
<artifactId>maven-surefire-plugin</artifactId>
20+
<version>2.17</version>
21+
<scope>test</scope>
22+
</dependency>
23+
<dependency>
24+
<groupId>org.apache.maven.surefire</groupId>
25+
<artifactId>surefire-junit4</artifactId>
26+
<version>2.17</version>
27+
</dependency>
28+
</dependencies>
1629
<build>
1730
<plugins>
1831
<plugin>

0 commit comments

Comments
 (0)