feat(sandbox): sync latest sandbox APIs#454
Conversation
Follow the latest sandbox OpenAPI contract with template filters, runtime injection management, and GitHub token updates. Keep runtime helpers, TypeScript declarations, tests, and executable examples aligned.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for managing runtime injections and updating GitHub tokens on sandboxes, along with template filtering capabilities in sandbox listings. It updates the client, facade, TypeScript definitions, examples, and adds corresponding tests. The review feedback highlights a critical issue where the newly added client methods (getSandboxInjections, updateSandboxInjections, and updateSandboxGithubToken) lack validation for sandboxID, potentially leading to invalid request paths. Additionally, updateSandboxInjections needs safer handling of the injections parameter to prevent a TypeError if a non-array value is provided.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Reject missing sandbox IDs before constructing request paths and return a typed SDK error for non-array injection payloads. Add regression coverage to ensure invalid input never reaches the HTTP client.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Review CompleteNo issues found in the latest PR head ( Validation completed:
A non-blocking PR review was submitted. No code changes were made by FennoAI. |
There was a problem hiding this comment.
Code Review
This pull request adds support for managing runtime injections and updating GitHub tokens on sandboxes, along with filtering sandboxes by template. It implements new methods on SandboxClient and Sandbox, updates TypeScript definitions, adds usage examples, and includes comprehensive tests. Feedback is provided to add a validation check for the authorizationToken parameter in updateSandboxGithubToken to prevent incomplete API requests.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Reject missing authorization tokens before issuing runtime GitHub token update requests. Extend argument validation coverage so incomplete payloads never reach the API.
This comment has been minimized.
This comment has been minimized.
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
No additional findings in the current head beyond the already-open review thread requesting validation for an empty authorizationToken before sending the GitHub-token update request. The earlier sandbox ID and injection-array validation feedback is fixed in f7b02c8.
Verified with npm run test:sandbox (122 passing), npm run check-type, targeted ESLint for changed JavaScript files, and git diff --check.
There was a problem hiding this comment.
Code Review
This pull request adds support for managing runtime injections and updating GitHub tokens on running sandboxes, alongside updating TypeScript definitions, examples, and unit tests. The feedback suggests improving robustness by normalizing the template query parameter to handle template objects and filtering out falsy values from the mapped injections array before sending the API request.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Accept template objects returned by the SDK when building sandbox list filters. Reject invalid injection entries explicitly so replacement updates cannot silently discard malformed rules.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Review CompleteNo issues found in the latest PR head ( Validation completed:
A non-blocking PR review was submitted. No code changes were made by FennoAI. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #454 +/- ##
==========================================
- Coverage 93.41% 93.41% -0.01%
==========================================
Files 14 14
Lines 2006 2050 +44
==========================================
+ Hits 1874 1915 +41
- Misses 132 135 +3
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Review Summary
No issues found in the latest head (e0dd387). The new template-object normalization and malformed-injection validation are covered by regression tests and do not introduce additional correctness, performance, security, or documentation concerns.
Verified with npm run test:sandbox (122 passing), npm run check-type, targeted ESLint for changed JavaScript files, and git diff --check.
There was a problem hiding this comment.
Code Review
This pull request introduces support for managing runtime injections and updating GitHub tokens on running sandboxes. It adds new methods (getInjections, updateInjections, updateGithubToken) to both SandboxClient and Sandbox classes, updates TypeScript type definitions, enhances template filtering when listing sandboxes, and updates relevant examples and test suites to cover these new capabilities. I have no feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
1 participant
Summary
Validation
npm run test:sandbox(121 passing)npm run check-typegit diff --checknames/isOwner, runtime injection get/update, GitHub token update, and Kodo resource mounting/writesLive smoke notes
Bad Gatewayin the current sandbox environmentupdateGithubToken()was verified independently against the live API