fix: decompose BlueprintCircuits before re-parametrization to fix QPY…#1045
Open
92meharali wants to merge 1 commit into
Open
fix: decompose BlueprintCircuits before re-parametrization to fix QPY…#104592meharali wants to merge 1 commit into
92meharali wants to merge 1 commit into
Conversation
… UUID mismatch (qiskit-community#1042) When a BlueprintCircuit (e.g. ZZFeatureMap) is passed to ComputeUncompute, its internal gate-level symbolic expressions may use the original parameter UUIDs from the blueprint's own ParameterView even after assign_parameters() is called on the outer circuit. This is because BlueprintCircuits use lazy evaluation via _build(), so the gate-level expressions are not fully materialized until the circuit is iterated or decomposed. When IBM Runtime serializes the SamplerV2 PUB via QPY for remote execution on real hardware, the expression tree on the backend contains the original blueprint UUID while the BindingsArray keys hold the new re-parametrized UUID, causing: QpyError: Cannot bind following parameters not present in expression: {Symbol { name: "x", uuid: ..., index: Some(0), vector: Some(...) }} Fix: call circuit.decompose() on both input circuits before assigning the new ParameterVectors. This forces full materialization of the circuit's gate-level instructions so that all parameter UUID references are consistent before re-parametrization, QPY serialization, and binding. Fixes: qiskit-community#1042
|
92meharali seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… UUID mismatch (#1042)
When a BlueprintCircuit (e.g. ZZFeatureMap) is passed to ComputeUncompute, its internal gate-level symbolic expressions may use the original parameter UUIDs from the blueprint's own ParameterView even after assign_parameters() is called on the outer circuit. This is because BlueprintCircuits use lazy evaluation via _build(), so the gate-level expressions are not fully materialized until the circuit is iterated or decomposed.
When IBM Runtime serializes the SamplerV2 PUB via QPY for remote execution on real hardware, the expression tree on the backend contains the original blueprint UUID while the BindingsArray keys hold the new re-parametrized UUID, causing:
Fix: call circuit.decompose() on both input circuits before assigning the new ParameterVectors. This forces full materialization of the circuit's gate-level instructions so that all parameter UUID references are consistent before re-parametrization, QPY serialization, and binding.
Fixes: #1042
Summary
ZZFeatureMap) before re-parametrization inBaseStateFidelity._construct_circuitsQpyError: Cannot bind following parameters not present in expressionwhen usingComputeUncompute+SamplerV2on IBM RuntimeFixes #1042
Test plan
pytest test/state_fidelities/test_compute_uncompute.pyZZFeatureMap+PegasosQSVC