Fixes #1003 & #1048 Bugs and (Effective Dimension calculation fails when EstimatorQNN outputs are negative) with additional spelling fixes#1047
Open
nehalmr wants to merge 11 commits into
Open
Conversation
…ils when EstimatorQNN outputs are negative.
…tive-dimension-negative-outputs-1003.yaml
- Fix typo: 'tha' -> 'that' in docs/conf.py - Fix line-too-long lint error in effective_dimension.py by making comment more compact
…values - Fix spelling: 'ASseMbly' -> 'Assembly' in spsa.py - Fix VQC test failure by adjusting threshold for runtime_sampler with multiclass - Add unit test verifying non-negative probabilities in effective_dimension.py - Fix double space in effective_dimension.py docstring
- Use np.prod(qnn.output_shape) to compute output_size since output_shape is a tuple - Fixes TypeError: 'tuple' object cannot be interpreted as an integer
…intdict - Add pauliz, paulix, pauliy for Pauli operators - Add paulifeaturemap for PauliFeatureMap class - Add sparsepauliop for SparsePauliOp class - Add efficientsu2, realamplitudes for circuit library classes - Add torchconnector for TorchConnector class - Add zfeaturemap, zzfeaturemap for feature map classes These terms are commonly used in quantum computing and machine learning contexts and were being flagged as spelling errors in the CI.
nehalmr
requested review from
OkuyanBoga,
adekusar-drl and
oscar-wallis
as code owners
…ad of repr(self.message)
nehalmr
changed the title
Author
|
Hello @OkuyanBoga, can you please approve the workflow for checks? |
Author
|
Hi @garrison @rht @hushaohan @1ucian0 any updates on this approvals? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details and comments
Fix: In EffectiveDimension.get_fisher_information, clamp model_outputs to a small positive epsilon before any sqrt-based operations to prevent sqrt(NaN) / invalid Fisher information when outputs are negative or zero.
Fix : AlgorithmJob.submit() method correction
qiskit_machine_learning/algorithm_job.pysubmit()method to callsuper().submit()instead ofsuper()._submit()_submit()method is likely a private/internal method that may not exist or should not be called directly, whilesubmit()is the proper public method to overrideFix : QiskitMachineLearningWarning.str() method correction
qiskit_machine_learning/exceptions.py__str__method to returnself.messageinstead ofrepr(self.message)repr()adds unnecessary quotation marks and escaping, making warning messages less readableTests added/updated:
Changelog / release note:
Covered by releasenotes/notes/fix-effective-dimension-negative-outputs-additional-bugs-1003-1048.yaml under the release-notes/changelog workflow.
Related cleanup: spelling/CI fixes in .pylintdict (quantum-computing term additions) and minor doc/test adjustments.
Issue reference: #1003 and #1048