feat: loosen NotNull checks

Author: qixils

pojos/src/main/java/dev/qixils/crowdcontrol/socket/Request.java

@@ -85,31 +85,26 @@ private Request(Request.@NotNull Builder builder) throws IllegalArgumentExceptio
 
 		// validate type & related arguments
 		this.type = ExceptionUtil.validateNotNull(builder.type, "type");
-		if (this.type.isEffectType()) {
-			if (builder.effect == null)
-				throw new IllegalArgumentException("effect cannot be null for effect packets");
-			if (builder.viewer == null)
-				throw new IllegalArgumentException("viewer cannot be null for effect packets");
-		} else {
-			if (builder.effect != null)
-				throw new IllegalArgumentException("effect cannot be non-null for non-effect packets");
-			if (builder.viewer != null)
-				throw new IllegalArgumentException("viewer cannot be non-null for non-effect packets");
-			if (builder.cost != null)
-				throw new IllegalArgumentException("cost cannot be non-null for non-effect packets");
-			if (builder.targets != null)
-				throw new IllegalArgumentException("targets cannot be non-null for non-effect packets");
-			if (builder.quantity != null)
-				throw new IllegalArgumentException("quantity cannot be non-null for non-effect packets");
-
-			if (builder.password == null && this.type == Type.LOGIN)
-				throw new IllegalArgumentException("password cannot be null for login packets");
-
-			if (builder.player == null && this.type == Type.PLAYER_INFO)
-				throw new IllegalArgumentException("player cannot be null for player info packets");
-		}
-
-		// other arguments
+        if (!this.type.isEffectType()) {
+            if (builder.effect != null)
+                throw new IllegalArgumentException("effect cannot be non-null for non-effect packets");
+            if (builder.viewer != null)
+                throw new IllegalArgumentException("viewer cannot be non-null for non-effect packets");
+            if (builder.cost != null)
+                throw new IllegalArgumentException("cost cannot be non-null for non-effect packets");
+            if (builder.targets != null)
+                throw new IllegalArgumentException("targets cannot be non-null for non-effect packets");
+            if (builder.quantity != null)
+                throw new IllegalArgumentException("quantity cannot be non-null for non-effect packets");
+
+            if (builder.password == null && this.type == Type.LOGIN)
+                throw new IllegalArgumentException("password cannot be null for login packets");
+
+            if (builder.player == null && this.type == Type.PLAYER_INFO)
+                throw new IllegalArgumentException("player cannot be null for player info packets");
+        }
+
+        // other arguments
 		this.effect = builder.effect == null ? null : builder.effect.toLowerCase(Locale.ENGLISH);
 		this.viewer = builder.viewer;
 		this.message = builder.message;

pojos/src/test/java/dev/qixils/crowdcontrol/socket/RequestTests.java

@@ -19,12 +19,6 @@ public void postProcessorTest() {
 	public void constructorTest() {
 		// new constructor tests //
 
-		// null effect test
-		Assertions.assertThrows(IllegalArgumentException.class,
-				() -> new Request.Builder().id(1).type(Request.Type.START).viewer("qixils").build());
-		// null viewer test
-		Assertions.assertThrows(IllegalArgumentException.class,
-				() -> new Request.Builder().id(1).type(Request.Type.START).effect("summon").build());
 		// negative cost test
 		Assertions.assertThrows(IllegalArgumentException.class,
 				() -> new Request.Builder().id(1).type(Request.Type.START).effect("summon").viewer("qixils").cost(-1).build());

receiver/src/main/java/dev/qixils/crowdcontrol/CrowdControl.java

@@ -328,8 +328,9 @@ else if (!annotation.effect().isEmpty())
 	 * @since 1.0.0
 	 */
 	@ApiStatus.AvailableSince("1.0.0")
-	public void registerHandler(@NotNull String effect, @NotNull Function<Request, Response> handler) {
-		effect = effect.toLowerCase(Locale.ENGLISH);
+	public void registerHandler(@Nullable String effect, @NotNull Function<Request, Response> handler) {
+		if (effect != null)
+			effect = effect.toLowerCase(Locale.ENGLISH);
 		if (effectHandlers.containsKey(effect) || asyncHandlers.containsKey(effect)) {
 			throw new IllegalArgumentException("The effect \"" + effect + "\" already has a handler.");
 		}
@@ -346,8 +347,9 @@ public void registerHandler(@NotNull String effect, @NotNull Function<Request, R
 	 * @since 2.0.0
 	 */
 	@ApiStatus.AvailableSince("2.0.0")
-	public void registerHandler(@NotNull String effect, @NotNull Consumer<Request> handler) {
-		effect = effect.toLowerCase(Locale.ENGLISH);
+	public void registerHandler(@Nullable String effect, @NotNull Consumer<Request> handler) {
+		if (effect != null)
+			effect = effect.toLowerCase(Locale.ENGLISH);
 		if (effectHandlers.containsKey(effect) || asyncHandlers.containsKey(effect)) {
 			throw new IllegalArgumentException("The effect \"" + effect + "\" already has a handler.");
 		}