fix: remove ID checks

just throws random errors from inconsistencies with CC's API, no reason for them really

Author: qixils

pojos/src/main/java/dev/qixils/crowdcontrol/socket/Request.java

@@ -86,8 +86,6 @@ public class Request implements JsonObject, Respondable {
 	private Request(Request.@NotNull Builder builder) throws IllegalArgumentException {
 		// validate request ID
 		this.id = builder.id;
-		if (this.id < 0)
-			throw new IllegalArgumentException("ID cannot be negative");
 
 		// validate type & related arguments
 		this.type = ExceptionUtil.validateNotNull(builder.type, "type");
@@ -126,10 +124,6 @@ private Request(Request.@NotNull Builder builder) throws IllegalArgumentExceptio
 			throw new IllegalArgumentException("duration cannot be negative");
 		this.duration = builder.duration;
 		this.parameters = builder.parameters;
-		if (this.id == 0 && this.type.usesIncrementalIds() == TriState.TRUE)
-			throw new IllegalArgumentException("ID cannot be 0 for effect packets");
-		if (this.id != 0 && this.type.usesIncrementalIds() == TriState.FALSE)
-			throw new IllegalArgumentException("ID must be 0 for non-effect packets");
 		if (this.type != Type.REMOTE_FUNCTION_RESULT && builder.value != null)
 			throw new IllegalArgumentException("value cannot be non-null for non-remote function result packets");
 		this.value = builder.value;

pojos/src/main/java/dev/qixils/crowdcontrol/socket/Response.java

@@ -113,10 +113,6 @@ public class Response implements JsonObject {
 			throw new IllegalArgumentException("type must not be a status if packetType is not EFFECT_STATUS");
 		if (this.packetType == PacketType.EFFECT_STATUS && builder.ids.isEmpty())
 			throw new IllegalArgumentException("ids cannot be empty if packetType is EFFECT_STATUS");
-		if (this.packetType != PacketType.EFFECT_RESULT && this.id != 0)
-			throw new IllegalArgumentException("id must be 0 if packetType is not EFFECT_RESULT");
-		if (this.packetType == PacketType.EFFECT_RESULT && this.id == 0)
-			throw new IllegalArgumentException("id must be non-zero if packetType is EFFECT_RESULT");
 
 		if (this.packetType == PacketType.REMOTE_FUNCTION && this.method == null)
 			throw new IllegalArgumentException("method cannot be null if packetType is REMOTE_FUNCTION");

pojos/src/test/java/dev/qixils/crowdcontrol/socket/RequestTests.java

@@ -19,9 +19,6 @@ public void postProcessorTest() {
 	public void constructorTest() {
 		// new constructor tests //
 
-		// negative ID test
-		Assertions.assertThrows(IllegalArgumentException.class,
-				() -> new Request.Builder().id(-1).type(Request.Type.START).effect("summon").viewer("qixils").build());
 		// null effect test
 		Assertions.assertThrows(IllegalArgumentException.class,
 				() -> new Request.Builder().id(1).type(Request.Type.START).viewer("qixils").build());