From d9063dd1a1bc123e793ae6c3979e0c6d926537c5 Mon Sep 17 00:00:00 2001 From: Joel Challis Date: Wed, 3 Jun 2026 16:25:53 +0100 Subject: [PATCH 1/3] Update docker workflow to actually run tests inside built container --- .github/workflows/docker-pr.yml | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/.github/workflows/docker-pr.yml b/.github/workflows/docker-pr.yml index 98be1e8..0d9e04d 100644 --- a/.github/workflows/docker-pr.yml +++ b/.github/workflows/docker-pr.yml @@ -3,6 +3,9 @@ name: Test Docker Image on: pull_request: +env: + TEST_TAG: qmkfm/qmk_cli:test + jobs: test: @@ -22,9 +25,6 @@ jobs: - uses: actions/checkout@v7 - - name: Run ci_tests - run: ./ci_tests - - name: Install dependencies run: | python3 -m pip install --upgrade pip @@ -35,7 +35,18 @@ jobs: run: | python3 -m build - - name: Build Container + - name: Build Test Container + uses: docker/build-push-action@v7 + with: + context: . + load: true + tags: ${{ env.TEST_TAG }} + + - name: Test + run: | + docker run --rm ${{ env.TEST_TAG }} qmk setup -y + + - name: Build All Containers uses: docker/build-push-action@v7 with: context: . From 7a2013dc179afd9b64ea74fa0e36186ee10b44bd Mon Sep 17 00:00:00 2001 From: zvecr Date: Mon, 29 Jun 2026 06:56:51 +0100 Subject: [PATCH 2/3] Update docker workflow to actually run tests inside built container --- .github/workflows/cli_setup.yml | 50 ++++++++++++++++++++++++++++++ .github/workflows/docker-pr.yml | 54 --------------------------------- 2 files changed, 50 insertions(+), 54 deletions(-) delete mode 100644 .github/workflows/docker-pr.yml diff --git a/.github/workflows/cli_setup.yml b/.github/workflows/cli_setup.yml index 9c7f3ab..fa7ba82 100644 --- a/.github/workflows/cli_setup.yml +++ b/.github/workflows/cli_setup.yml @@ -64,3 +64,53 @@ jobs: - name: Run ci_tests shell: msys2 {0} run: ./ci_tests -a + + test_docker_container: + needs: test_cli_base_container + + runs-on: ubuntu-latest + + env: + TEST_TAG: qmkfm/qmk_cli:test + + steps: + - name: Set up Python + uses: actions/setup-python@v6 + with: + python-version: '3.9' + + - name: Set up QEMU + uses: docker/setup-qemu-action@v4 + + - name: Set up Docker Buildx + uses: docker/setup-buildx-action@v4 + + - uses: actions/checkout@v7 + + - name: Install dependencies + run: | + python3 -m pip install --upgrade pip + pip install setuptools wheel + pip install --group dev + + - name: Build Python + run: | + python3 -m build + + - name: Build Test Container + uses: docker/build-push-action@v7 + with: + context: . + load: true + tags: ${{ env.TEST_TAG }} + + - name: Test + run: | + docker run --rm -v ${{ github.workspace }}:/qmk_cli ${{ env.TEST_TAG }} /qmk_cli/ci_tests -a + + - name: Build All Containers + uses: docker/build-push-action@v7 + with: + context: . + target: full + platforms: linux/amd64,linux/arm64 diff --git a/.github/workflows/docker-pr.yml b/.github/workflows/docker-pr.yml deleted file mode 100644 index 0d9e04d..0000000 --- a/.github/workflows/docker-pr.yml +++ /dev/null @@ -1,54 +0,0 @@ -name: Test Docker Image - -on: - pull_request: - -env: - TEST_TAG: qmkfm/qmk_cli:test - -jobs: - test: - - runs-on: ubuntu-latest - - steps: - - name: Set up Python - uses: actions/setup-python@v6 - with: - python-version: '3.9' - - - name: Set up QEMU - uses: docker/setup-qemu-action@v4 - - - name: Set up Docker Buildx - uses: docker/setup-buildx-action@v4 - - - uses: actions/checkout@v7 - - - name: Install dependencies - run: | - python3 -m pip install --upgrade pip - pip install setuptools wheel - pip install --group dev - - - name: Build Python - run: | - python3 -m build - - - name: Build Test Container - uses: docker/build-push-action@v7 - with: - context: . - load: true - tags: ${{ env.TEST_TAG }} - - - name: Test - run: | - docker run --rm ${{ env.TEST_TAG }} qmk setup -y - - - name: Build All Containers - uses: docker/build-push-action@v7 - with: - context: . - target: full - platforms: linux/amd64,linux/arm64 From 33cc6a2ba43a98cfc4efb9475733e6b539d3e786 Mon Sep 17 00:00:00 2001 From: zvecr Date: Mon, 29 Jun 2026 07:03:37 +0100 Subject: [PATCH 3/3] Set cwd? --- .github/workflows/cli_setup.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cli_setup.yml b/.github/workflows/cli_setup.yml index fa7ba82..ef47463 100644 --- a/.github/workflows/cli_setup.yml +++ b/.github/workflows/cli_setup.yml @@ -106,7 +106,7 @@ jobs: - name: Test run: | - docker run --rm -v ${{ github.workspace }}:/qmk_cli ${{ env.TEST_TAG }} /qmk_cli/ci_tests -a + docker run --rm -v ${{ github.workspace }}:/qmk_cli -w /qmk_cli ${{ env.TEST_TAG }} /qmk_cli/ci_tests -a - name: Build All Containers uses: docker/build-push-action@v7