Ensure sparsity nnz stays the same and removed useless returns.

Author: Jonas Breuling

src/bindings.cpp.in

@@ -274,7 +274,7 @@ void PyQOCOSolver::update_vector_data(py::object cnew, py::object bnew, py::obje
         hnew_ptr = (QOCOFloat *)buf.ptr;
     }
 
-    return qoco_update_vector_data(this->_solver, cnew_ptr, bnew_ptr, hnew_ptr);
+    qoco_update_vector_data(this->_solver, cnew_ptr, bnew_ptr, hnew_ptr);
 }
 
 void PyQOCOSolver::update_matrix_data(py::object Pxnew, py::object Axnew, py::object Gxnew)
@@ -310,7 +310,7 @@ void PyQOCOSolver::update_matrix_data(py::object Pxnew, py::object Axnew, py::ob
         Gxnew_ptr = (QOCOFloat *)buf.ptr;
     }
 
-    return qoco_update_matrix_data(this->_solver, Pxnew_ptr, Axnew_ptr, Gxnew_ptr);
+    qoco_update_matrix_data(this->_solver, Pxnew_ptr, Axnew_ptr, Gxnew_ptr);
 }
 
 PYBIND11_MODULE(@QOCO_EXT_MODULE_NAME@, m)

src/qoco/interface.py

@@ -144,16 +144,22 @@ def update_matrix_data(self, P=None, A=None, G=None):
             if not isinstance(P, np.ndarray):
                 P = np.array(P)
             P = P.astype(np.float64)
+            if P.shape[0] != self.P.nnz:
+                raise ValueError(f"P size must be {self.P.nnz}")
 
         if A is not None:
             if not isinstance(A, np.ndarray):
                 A = np.array(A)
             A = A.astype(np.float64)
+            if A.shape[0] != self.A.nnz:
+                raise ValueError(f"A size must be {self.A.nnz}")
 
         if G is not None:
             if not isinstance(G, np.ndarray):
                 G = np.array(G)
             G = G.astype(np.float64)
+            if G.shape[0] != self.G.nnz:
+                raise ValueError(f"G size must be {self.G.nnz}")
 
         return self._solver.update_matrix_data(P, A, G)
 

tests/test_update_data.py

@@ -207,3 +207,19 @@ def test_update_vector_data_float_conversion(setup_qoco):
     prob.update_vector_data(c=c_int, b=b_int, h=h_int)
     res = prob.solve()
     assert res.status in ["QOCO_SOLVED", "QOCO_SOLVED_INACCURATE"]
+
+def test_update_matrix_data_invalid_size(setup_qoco):
+    """Test that updating with wrong size matrix data raises error."""
+    prob = setup_qoco
+
+    # Test P with wrong size
+    with pytest.raises(ValueError, match="P size must be"):
+        prob.update_matrix_data(P=np.array([1, 2, 3]))
+
+    # Test A with wrong size
+    with pytest.raises(ValueError, match="A size must be"):
+        prob.update_matrix_data(A=np.array([1, 2]))
+
+    # Test G with wrong size
+    with pytest.raises(ValueError, match="G size must be"):
+        prob.update_matrix_data(G=np.array([1, 2]))