Fix missing test deps, docs, and downgrade CI#232
Merged
Krastanov merged 1 commit intoJun 18, 2026
Conversation
8a882bb to
0586091
Compare
0586091 to
212fc85
Compare
212fc85 to
fe245cb
Compare
fe245cb to
bf81763
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkdocs=:exportsbuild passes.Makie,SciMLBaseforODEProblem/solve, andOrdinaryDiffEqLowOrderRKforDP5.sol.u[end].allow_reresolve=falseand raise the minimum compat floors needed for the downgraded root manifest and no-reresolve test environment.Downgrade bounds
Adapt,FFTW,RecursiveArrayTools, andSpecialFunctionslower bounds to versions that resolve together underjulia-downgrade-compatforced deps.MKL_jll,SciMLBase, andSciMLOperatorsso the test environment does not resolve incompatible SciML/LinearSolve transitives.Validation
2tests passed.9tests passed.JULIA_PKG_SERVER_REGISTRY_PREFERENCE=eager julia --project=docs docs/make.jlJULIA_PKG_SERVER_REGISTRY_PREFERENCE=eager julia +1.10 /tmp/julia-downgrade-compat.jl "Pkg,TOML,InteractiveUtils,Random,LinearAlgebra,SparseArrays" "." "forcedeps" "1.10"JULIA_PKG_SERVER_REGISTRY_PREFERENCE=eager julia +1.10 --project=. -e 'using Pkg; Pkg.build(verbose=true)'JULIA_PKG_SERVER_REGISTRY_PREFERENCE=eager julia +1.10 --project=. -e 'import Pkg; Pkg.test(; coverage=true, julia_args=["--check-bounds=yes", "--compiled-modules=yes", "--depwarn=yes"], test_args=["general"], force_latest_compatible_version=false, allow_reresolve=false)'passed:2128pass,2broken.Notes
No Buildkite/JET changes remain in this PR.
No
test/runtests.jlchanges remain in this PR.No plotting test rewrite remains in this PR.
Repo-wide whitespace check reports pre-existing unrelated whitespace issues; this PR diff is clean under
git diff --check.GitHub Downgrade
test (1.10)passed on commitfe245cb.Removed
JETfromtest/Project.toml;test/runtests.jlnow installs it withPkg.add("JET")only whenJET_TEST=true, matching the conditional GPU dependency pattern.Latest validation after the JET change:
julia --project=. -e 'using QuantumOpticsBase; @assert isdefined(@__MODULE__, :blochsphereplot_axis); @assert !isdefined(@__MODULE__, :JET)'passed.Latest normal
Pkg.test(; test_args=["general"])on local Julia 1.12 got past JET precompilation and then failed intest/test_plotting.jlwithblochsphereplot_axisnot in scope inside the test item; this is separate from the JET dependency change.