Draft: Embedding with lazy semantics#88
Conversation
Basic version.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #88 +/- ##
==========================================
- Coverage 96.46% 96.35% -0.12%
==========================================
Files 26 26
Lines 3363 3370 +7
==========================================
+ Hits 3244 3247 +3
- Misses 119 123 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I am in favor of this getting merged. This new functionality is not exported, so changes to it will still be possible. QuantumSymbolics and QuantumSavory would like to use it already, so there will be feedback on it as well. |
|
Ok, perhaps I'll add some simple tests first. |
|
Any chance we can remove the |
Huh, that's an interesting suggestion. Currently we define operators wrt to a concrete composite basis with integer indices. You could lazily embed operators on two qubits, then lazily embed the result into a larger system later. Not sure if that is currently supported, but it would be easy enough to do for the LazyTensor case. Another useful feature for this kind of use-case would be a "labeled basis". If we had that, we could map from smaller <-> larger composite systems by label. |
|
Maybe a first step would be to permit Named bases would also be nice, but I consider them separate from this. |
|
I converted this to draft, just to make it easier to track what I need to review on my github dashboard. |
Basic version.