Skip to content

Commit c23b6cf

Browse files
committed
Review fixes
1 parent 7274709 commit c23b6cf

6 files changed

Lines changed: 19 additions & 19 deletions

File tree

android/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,6 @@ android {
5353

5454
dependencies {
5555
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
56-
implementation "io.qonversion:sandwich:6.0.6"
56+
implementation "io.qonversion:sandwich:6.0.8"
5757
implementation 'com.google.code.gson:gson:2.9.0'
5858
}

example/lib/nocodes_view.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ class _NoCodesViewState extends State<NoCodesView> {
6060

6161
_screenFailedToLoadStream = NoCodes.getSharedInstance().screenFailedToLoadStream.listen((event) {
6262
_addEvent('Screen Failed to Load: ${event.payload}');
63-
// NoCodes.getSharedInstance().close();
63+
NoCodes.getSharedInstance().close();
6464
});
6565
}
6666

@@ -78,13 +78,13 @@ class _NoCodesViewState extends State<NoCodesView> {
7878
// Set presentation style config before showing screen
7979
final config = NoCodesPresentationConfig(
8080
animated: true,
81-
presentationStyle: NoCodesPresentationStyle.push,
81+
presentationStyle: NoCodesPresentationStyle.fullScreen,
8282
);
8383

84-
await NoCodes.getSharedInstance().setScreenPresentationConfig(config, contextKey: 'kamo_test');
84+
await NoCodes.getSharedInstance().setScreenPresentationConfig(config, contextKey: 'your_context_key');
8585
_addEvent('Presentation config set');
8686

87-
await NoCodes.getSharedInstance().showScreen('kamo_test');
87+
await NoCodes.getSharedInstance().showScreen('your_context_key');
8888
} catch (e) {
8989
print('Error showing screen: $e');
9090
_addEvent('Error showing screen: $e');

ios/Classes/NoCodesPlugin.swift

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -119,22 +119,22 @@ extension NoCodesPlugin: NoCodesEventListener {
119119

120120
DispatchQueue.main.async {
121121
switch event {
122-
case eventScreenShown:
122+
case self.eventScreenShown:
123123
self.screenShownEventStreamHandler?.eventSink?(jsonString)
124124

125-
case eventFinished:
125+
case self.eventFinished:
126126
self.finishedEventStreamHandler?.eventSink?(jsonString)
127127

128-
case eventActionStarted:
128+
case self.eventActionStarted:
129129
self.actionStartedEventStreamHandler?.eventSink?(jsonString)
130130

131-
case eventActionFailed:
131+
case self.eventActionFailed:
132132
self.actionFailedEventStreamHandler?.eventSink?(jsonString)
133133

134-
case eventActionFinished:
134+
case self.eventActionFinished:
135135
self.actionFinishedEventStreamHandler?.eventSink?(jsonString)
136136

137-
case eventScreenFailedToLoad:
137+
case self.eventScreenFailedToLoad:
138138
self.screenFailedToLoadEventStreamHandler?.eventSink?(jsonString)
139139

140140
default:

ios/qonversion_flutter.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Pod::Spec.new do |s|
1616
s.source_files = 'Classes/**/*'
1717
s.dependency 'Flutter'
1818
s.platform = :ios, '13.0'
19-
s.dependency "QonversionSandwich", "6.0.6"
19+
s.dependency "QonversionSandwich", "6.0.8"
2020

2121
# Flutter.framework does not contain a i386 slice. Only x86_64 simulators are supported.
2222
s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES', 'VALID_ARCHS[sdk=iphonesimulator*]' => 'x86_64' }

lib/src/nocodes/presentation_config.dart

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,3 @@
1-
static const kPush = 'Push';
2-
static const kFullScreen = 'FullScreen';
3-
static const kPopover = 'Popover';
4-
static const kAnimated = 'animated';
5-
static const kPresentationStyle = 'presentationStyle';
6-
71
/// Presentation style for NoCodes screens
82
enum NoCodesPresentationStyle {
93
push,
@@ -13,6 +7,12 @@ enum NoCodesPresentationStyle {
137

148
/// Configuration for NoCodes screen presentation
159
class NoCodesPresentationConfig {
10+
static const kPush = 'Push';
11+
static const kFullScreen = 'FullScreen';
12+
static const kPopover = 'Popover';
13+
static const kAnimated = 'animated';
14+
static const kPresentationStyle = 'presentationStyle';
15+
1616
final bool animated;
1717
final NoCodesPresentationStyle presentationStyle;
1818

macos/qonversion_flutter.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Pod::Spec.new do |s|
1616
s.source_files = 'Classes/**/*'
1717
s.dependency 'FlutterMacOS'
1818
s.platform = :osx, '10.12'
19-
s.dependency "QonversionSandwich", "6.0.6"
19+
s.dependency "QonversionSandwich", "6.0.8"
2020

2121
s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES' }
2222
s.swift_version = '5.0'

0 commit comments

Comments
 (0)