Skip to content

Commit 62d5c6f

Browse files
authored
Merge pull request #374 from qonversion/tech/sc-40232/sourceVersion
2 parents 14ac9ea + fb6f1d0 commit 62d5c6f

10 files changed

Lines changed: 23 additions & 16 deletions

File tree

android/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ def kotlin_version = getExtOrDefault("kotlinVersion")
8080
dependencies {
8181
implementation "com.facebook.react:react-android"
8282
implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version"
83-
implementation "io.qonversion:sandwich:6.0.6"
83+
implementation "io.qonversion:sandwich:6.0.10"
8484
}
8585

8686
if (isNewArchitectureEnabled()) {

android/src/main/java/com/qonversion/reactnativesdk/NoCodesModule.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@ class NoCodesModule(private val reactContext: ReactApplicationContext) : NativeN
3232
}
3333

3434
@ReactMethod
35-
override fun initialize(projectKey: String) {
35+
override fun initialize(projectKey: String, source: String, version: String) {
36+
noCodesSandwich.storeSdkInfo(reactContext, source, version)
3637
noCodesSandwich.initialize(reactContext, projectKey, null, null, null)
3738
noCodesSandwich.setDelegate(noCodesEventListener)
3839
noCodesSandwich.setScreenCustomizationDelegate()

example/ios/Podfile.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ PODS:
1919
- fmt
2020
- glog
2121
- hermes-engine
22-
- QonversionSandwich (= 6.0.8)
22+
- QonversionSandwich (= 6.0.10)
2323
- RCT-Folly
2424
- RCT-Folly/Fabric
2525
- RCTRequired
@@ -43,7 +43,7 @@ PODS:
4343
- SocketRocket
4444
- Yoga
4545
- Qonversion/Main (5.13.3)
46-
- QonversionSandwich (6.0.8):
46+
- QonversionSandwich (6.0.10):
4747
- NoCodes (= 0.1.3)
4848
- Qonversion (= 5.13.3)
4949
- RCT-Folly (2024.11.18.00):
@@ -2406,8 +2406,8 @@ SPEC CHECKSUMS:
24062406
hermes-engine: 4f07404533b808de66cf48ac4200463068d0e95a
24072407
NoCodes: 21b87d320a16758c6eb79167ff98010d81b4894e
24082408
Qonversion: 2b32ae8681de3ba02db5b5ed69c8f213ac4a28fa
2409-
qonversion-react-native-sdk: 046d871f4599e0f6e8097a0d660bf3091493888f
2410-
QonversionSandwich: 8a8638ee1fbdf304f0629f064712d206c390fedf
2409+
qonversion-react-native-sdk: dc32c5cf63d9e4f1d650ba3692209d09f115df06
2410+
QonversionSandwich: 6a8c8704a57bc97393ec1684c8932402aa0b7ba9
24112411
RCT-Folly: 59ec0ac1f2f39672a0c6e6cecdd39383b764646f
24122412
RCTDeprecation: efa5010912100e944a7ac9a93a157e1def1988fe
24132413
RCTRequired: bbc4cf999ddc4a4b076e076c74dd1d39d0254630

fastlane/Fastfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
def update_js(new_version)
22
path = Dir['../src/**/QonversionInternal.ts'].first
3-
regex = /const sdkVersion = ".*";/
4-
result_value = "const sdkVersion = \"#{new_version}\";"
3+
regex = /export const sdkVersion = ".*";/
4+
result_value = "export const sdkVersion = \"#{new_version}\";"
55

66
update_file(path, regex, result_value)
77
end

ios/RNNoCodes.mm

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,10 @@ - (instancetype)init {
1818
return self;
1919
}
2020

21-
- (void)initialize:(NSString *)projectKey {
22-
[self.impl initializeWithProjectKey:projectKey];
21+
- (void)initialize:(NSString *)projectKey
22+
source:(NSString *)source
23+
version:(NSString *)version {
24+
[self.impl initializeWithProjectKey:projectKey source:source version:version];
2325
}
2426

2527
- (void)setScreenPresentationConfig:(NSDictionary *)configData

ios/RNNoCodesImpl.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ public class RNNoCodesImpl: NSObject {
4242
}
4343

4444
@objc
45-
public func initialize(projectKey: String) {
45+
public func initialize(projectKey: String, source: String, version: String) {
46+
// Ignore source and version, because it's taken from the Qonversion SDK.
4647
noCodesSandwich?.initialize(projectKey: projectKey)
4748
}
4849

qonversion-react-native-sdk.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,6 @@ Pod::Spec.new do |s|
1616
s.source_files = "ios/**/*.{h,m,mm,cpp,swift}"
1717
s.private_header_files = "ios/**/*.h"
1818

19-
s.dependency "QonversionSandwich", "6.0.8"
19+
s.dependency "QonversionSandwich", "6.0.10"
2020
install_modules_dependencies(s)
2121
end

src/internal/NoCodesInternal.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ import ScreenPresentationConfig from '../dto/ScreenPresentationConfig';
66
import NoCodesError from '../dto/NoCodesError';
77
import {NoCodesErrorCode} from '../dto/enums';
88
import RNNoCodes, {type NoCodeEvent} from './specs/NativeNoCodesModule';
9+
import {sdkSource, sdkVersion} from './QonversionInternal';
10+
911
const EVENT_SCREEN_SHOWN = "nocodes_screen_shown";
1012
const EVENT_FINISHED = "nocodes_finished";
1113
const EVENT_ACTION_STARTED = "nocodes_action_started";
@@ -17,7 +19,7 @@ export default class NoCodesInternal implements NoCodesApi {
1719
private noCodesListener: NoCodesListener | null = null;
1820

1921
constructor(config: NoCodesConfig) {
20-
RNNoCodes.initialize(config.projectKey);
22+
RNNoCodes.initialize(config.projectKey, sdkSource, sdkVersion);
2123

2224
if (config.noCodesListener) {
2325
this.setNoCodesListener(config.noCodesListener);

src/internal/QonversionInternal.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,16 @@ import PromotionalOffer from '../dto/PromotionalOffer';
2323
import RNQonversion from './specs/NativeQonversionModule';
2424
import type { QPromoOfferDetails } from './specs/NativeQonversionModule';
2525

26-
const sdkVersion = "9.0.2";
26+
export const sdkVersion = "9.0.2";
27+
export const sdkSource = "rn";
2728

2829
export default class QonversionInternal implements QonversionApi {
2930

3031
private entitlementsUpdateListener: EntitlementsUpdateListener | null = null;
3132
private promoPurchasesDelegate: PromoPurchasesListener | null = null;
3233

3334
constructor(qonversionConfig: QonversionConfig) {
34-
RNQonversion.storeSDKInfo("rn", sdkVersion);
35+
RNQonversion.storeSDKInfo(sdkSource, sdkVersion);
3536
RNQonversion.initializeSdk(
3637
qonversionConfig.projectKey,
3738
qonversionConfig.launchMode,

src/internal/specs/NativeNoCodesModule.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export type NoCodeEvent = {
99
};
1010

1111
export interface Spec extends TurboModule {
12-
initialize(projectKey: string): void;
12+
initialize(projectKey: string, source: string, version: string): void;
1313
setScreenPresentationConfig(configData: Object, contextKey?: string): Promise<boolean>;
1414
showScreen(contextKey: string): Promise<boolean>;
1515
close(): Promise<boolean>;

0 commit comments

Comments
 (0)