Skip to content

Commit 862d80e

Browse files
committed
Screen presentation config fixes
1 parent 24370ea commit 862d80e

File tree

6 files changed

+17
-30
lines changed

6 files changed

+17
-30
lines changed

example/App.js

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -344,20 +344,7 @@ export class QonversionSample extends React.PureComponent {
344344
<TouchableOpacity
345345
style={styles.additionalButton}
346346
onPress={() => {
347-
this.setState({loading: true});
348-
NoCodes.getSharedInstance().showScreen(NoCodeScreenContextKey).then(() => {
349-
this.setState({loading: false});
350-
}).catch(error => {
351-
this.setState({loading: false});
352-
Alert.alert(
353-
'Error',
354-
error.message,
355-
[
356-
{text: 'OK'},
357-
],
358-
{cancelable: true}
359-
);
360-
});
347+
NoCodes.getSharedInstance().showScreen(NoCodeScreenContextKey)
361348
}}
362349
>
363350
<Text style={styles.additionalButtonsText}>Show NoCodes Screen</Text>

src/NoCodesApi.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {ScreenPresentationConfig} from './dto/ScreenPresentationConfig';
1+
import ScreenPresentationConfig from './dto/ScreenPresentationConfig';
22

33
export default interface NoCodesApi {
44
/**
@@ -7,18 +7,16 @@ export default interface NoCodesApi {
77
* @param contextKey the context key of the screen, to which a config should be applied.
88
* If not provided, the config is used for all the screens.
99
*/
10-
setScreenPresentationConfig(config: ScreenPresentationConfig, contextKey?: string): Promise<void>;
10+
setScreenPresentationConfig(config: ScreenPresentationConfig, contextKey?: string): void;
1111

1212
/**
1313
* Show the screen using its context key.
1414
* @param contextKey the context key of the screen which must be shown
15-
* @returns promise to await for completion.
1615
*/
17-
showScreen(contextKey: string): Promise<void>;
16+
showScreen(contextKey: string): void;
1817

1918
/**
2019
* Close the current opened No-Code screen.
21-
* @returns promise to await for completion.
2220
*/
23-
close(): Promise<void>;
21+
close(): void;
2422
}

src/dto/ScreenPresentationConfig.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import {ScreenPresentationStyle} from './enums';
22

3-
export class ScreenPresentationConfig {
3+
class ScreenPresentationConfig {
44
/**
55
* Describes how screens will be displayed.
66
* For mode details see the enum description.
@@ -20,3 +20,5 @@ export class ScreenPresentationConfig {
2020
this.animated = animated === undefined ? true : animated;
2121
}
2222
}
23+
24+
export default ScreenPresentationConfig;

src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ export { default as PurchaseUpdateModel } from './dto/PurchaseUpdateModel';
1515
export type { PromoPurchasesListener } from './dto/PromoPurchasesListener';
1616
export { default as RemoteConfig } from './dto/RemoteConfig';
1717
export { default as RemoteConfigList } from './dto/RemoteConfigList';
18-
export { ScreenPresentationConfig } from './dto/ScreenPresentationConfig';
1918
export { default as SubscriptionPeriod } from './dto/SubscriptionPeriod';
2019
export { default as QonversionError } from './dto/QonversionError';
2120
export { default as User } from './dto/User';
@@ -35,6 +34,7 @@ export { default as PurchaseOptionsBuilder } from './dto/PurchaseOptionsBuilder'
3534
export { default as PurchaseOptions } from './dto/PurchaseOptionsBuilder';
3635

3736
// NoCode exports
37+
export { default as ScreenPresentationConfig } from './dto/ScreenPresentationConfig';
3838
export { default as NoCodes } from './NoCodes';
3939
export type { default as NoCodesApi } from './NoCodesApi';
4040
export { default as NoCodesConfig } from './NoCodesConfig';

src/internal/Mapper.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ import SKProductDiscount from "../dto/storeProducts/SKProductDiscount";
3131
import SKSubscriptionPeriod from "../dto/storeProducts/SKSubscriptionPeriod";
3232
import SkuDetails from "../dto/storeProducts/SkuDetails";
3333
import User from '../dto/User';
34-
import {ScreenPresentationConfig} from '../dto/ScreenPresentationConfig';
34+
import ScreenPresentationConfig from '../dto/ScreenPresentationConfig';
3535
import Experiment from "../dto/Experiment";
3636
import ExperimentGroup from "../dto/ExperimentGroup";
3737
import SubscriptionPeriod from "../dto/SubscriptionPeriod";

src/internal/NoCodesInternal.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import NoCodesApi from "../NoCodesApi";
33
import NoCodesConfig from "../NoCodesConfig";
44
import Mapper from "./Mapper";
55
import {NoCodesListener} from '../dto/NoCodesListener';
6-
import {ScreenPresentationConfig} from '../dto/ScreenPresentationConfig';
6+
import ScreenPresentationConfig from '../dto/ScreenPresentationConfig';
77
import NoCodesError from '../dto/NoCodesError';
88
import {NoCodesErrorCode} from '../dto/enums';
99

@@ -25,17 +25,17 @@ export default class NoCodesInternal implements NoCodesApi {
2525
}
2626
}
2727

28-
async setScreenPresentationConfig(config: ScreenPresentationConfig, contextKey?: string): Promise<void> {
28+
async setScreenPresentationConfig(config: ScreenPresentationConfig, contextKey?: string) {
2929
const data = Mapper.convertScreenPresentationConfig(config);
30-
return await RNNoCodes.setScreenPresentationConfig(data, contextKey);
30+
await RNNoCodes.setScreenPresentationConfig(data, contextKey);
3131
}
3232

33-
async showScreen(contextKey: string): Promise<void> {
34-
return await RNNoCodes.showScreen(contextKey);
33+
async showScreen(contextKey: string) {
34+
await RNNoCodes.showScreen(contextKey);
3535
}
3636

37-
async close(): Promise<void> {
38-
return await RNNoCodes.close();
37+
async close() {
38+
await RNNoCodes.close();
3939
}
4040

4141
setNoCodesListener(listener: NoCodesListener) {

0 commit comments

Comments
 (0)