version.core does not work with ${revision} version

[olibraga]

If pom contains
<version>${revision}</version>
and
<properties><revision>1.2.r</revision></properties>

the value of ${version.core} is 0.0.0 instead of 1.2.3

[qoomon]

@olibraga why you need to use ${revision} together with this extension?

[olibraga]

It's so a continuous integration system (CircleCI) can set the version to whatever it needs to by overriding the revision property.

[qoomon]

unfortunately that case is not supported. However you could disable versioning by setting environment variable VERSIONING_DISABLE=true or mvn … -Dversioning.disable see https://github.com/qoomon/maven-git-versioning-extension?tab=readme-ov-file#parameters--environment-variables

[qoomon]

Out of curiosity what would be your expected behaviour of this extension? Disable the extension automatically if revision property is set?

[jmbe]

@olibraga Noticed this too, but it appears to work fine to simply refer to ${revision} instead of ${version.core} in the config.

This is assuming a version like <version>${revision}${changelist}</version> and a .mvn/maven.config such as:

-Drevision=25.10
-Dchangelist=-SNAPSHOT

And configuration like:

<!-- Always use SNAPSHOT, as releases are built from tags instead -->
<ref type="branch">
  <pattern>develop|master|main</pattern>
  <version>${revision}-SNAPSHOT</version>
</ref>

<ref type="branch">
  <pattern><![CDATA[feature/(?<feature>.+)]]></pattern>
  <version>${revision}-${ref.feature}-SNAPSHOT</version>
</ref>

Overriding revision shows the expected version:

./mvnw help:evaluate -Dexpression=project.version -q -DforceStdout -Drevision=1.2.3

# 1.2.3-SNAPSHOT

(NB: While I have just started migrating to maven-git-versioning-extension, I note that the remnant changelist property pasted above is actually redundant or even conflicting now, since it will be automatically determined by the extension anyway: use SNAPSHOT for all branches, and simply skip SNAPSHOT if building a release from a tag.)

@qoomon No, please don't disable extension automatically when detecting revision property! 😄 They are useful together, and as you note there is already support for disabling the extension if you really want to take complete control.

The above means we can continue changing revision in a single place in a single file (not repeated in all pom files of a multi-module project) and still having the benefit of automatically disambiguated versions for feature branches etc.