Skip to content

QCLINUX: arm64: dts: qcom: lemans: Add SAIL Mailbox device tree overlay#1294

Merged
Komal-Bajaj merged 2 commits into
qualcomm-linux:tech/overlay/dtfrom
snegi-qti:sail_mb_changes
Jun 3, 2026
Merged

QCLINUX: arm64: dts: qcom: lemans: Add SAIL Mailbox device tree overlay#1294
Komal-Bajaj merged 2 commits into
qualcomm-linux:tech/overlay/dtfrom
snegi-qti:sail_mb_changes

Conversation

@snegi-qti

Copy link
Copy Markdown

Add lemans-sail-mb.dtso overlay for Lemans platform providing:

  • ipcc_computeL1: IPCC Compute-L1 controller
  • sail_mailbox: SAIL Mailbox device node

Also add IPCC_CLIENT_SAIL0/1/2/3 client ID definitions to the qcom-ipcc dt-bindings header.

CRs-Fixed: 4557036

@qcomlnxci qcomlnxci requested review from a team, quic-tingweiz, rrnayak and trsoni and removed request for a team June 2, 2026 17:27
@qlijarvis

Copy link
Copy Markdown

PR #1294 — validate-patch

PR: #1294

Verdict Issues Detailed Report
N/A 0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit
Verdict: N/A — click to expand

🔍 Patch Validation

PR: #1294 - QCLINUX: arm64: dts: qcom: lemans: Add SAIL Mailbox device tree overlay
Upstream commit: N/A (vendor-only)
Verdict: ⏭️ SKIP — Validation not applicable

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: vendor-only commit
Body preserves rationale Clear description of added nodes
Fixes tag present/correct N/A New feature, no Fixes tag needed
Authorship preserved Signed-off-by present
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile Adds lemans-sail-mb.dtbo to build
arch/arm64/boot/dts/qcom/lemans-sail-mb.dtso New overlay with IPCC and SAIL mailbox nodes
include/dt-bindings/mailbox/qcom-ipcc.h Adds IPCC_CLIENT_SAIL0/1/2/3 definitions

Issues

None — commit is well-formed for a vendor-only change.

Verdict

This is a vendor-only commit (QCLINUX: prefix) adding Lemans SAIL mailbox support. No upstream lore link is expected or required. The commit message is clear, authorship is correct, and the diff adds appropriate device tree overlay and bindings. Validation against upstream is not applicable.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

@qlijarvis

Copy link
Copy Markdown

PR #1294 — checker-log-analyzer

PR: #1294
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26836625844

Checker Result Summary
Checker Result Summary
checkpatch 3 commits with warnings (DT_SPLIT_BINDING, missing commit description)
dt-binding-check ⏭️ No binding changes
dtb-check Pre-existing tree issues (monaco.dtsi interrupts, hamoa-camera reg_format, qcs6490 reg_format)
sparse-check Passed
check-uapi-headers Passed
check-patch-compliance All 6 commits fail prefix validation (QCLINUX:, PENDING:, no prefix)
tag-check 1 commit missing required prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1294 — QCLINUX: arm64: dts: qcom: lemans: Add SAIL Mailbox device tree overlay
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26836625844

Checker Result Summary
checkpatch 3 commits with warnings (DT_SPLIT_BINDING, missing commit description)
dt-binding-check ⏭️ No binding changes
dtb-check Pre-existing tree issues (monaco.dtsi interrupts, hamoa-camera reg_format, qcs6490 reg_format)
sparse-check Passed
check-uapi-headers Passed
check-patch-compliance All 6 commits fail prefix validation (QCLINUX:, PENDING:, no prefix)
tag-check 1 commit missing required prefix

❌ checkpatch

Root cause: Three commits have style warnings — one for DT binding split requirement, two for missing commit descriptions.

Failure details:

Commit ad5b447 ("QCLINUX: arm64: dts: qcom: lemans: Add SAIL Mailbox device tree overlay"):

WARNING: DT binding docs and includes should be a separate patch.
ad5b44728a67cd4f64cb1b3babb0b251f9b53320 total: 0 errors, 1 warnings, 0 checks, 82 lines checked

This commit modifies include/dt-bindings/mailbox/qcom-ipcc.h (adding IPCC_CLIENT_SAIL0/1/2/3 definitions) alongside the DTS overlay. Checkpatch requires DT binding header changes to be in a separate patch.

Commit b7de1d7 ("QCLINUX: arm64: dts: qcom: Enable combo mode for CSI1 port..."):

WARNING: Missing commit description - Add an appropriate one
b7de1d752e129c1883a76fa496545847834881b4 total: 0 errors, 1 warnings, 0 checks, 151 lines checked

The commit subject is overly long (wraps into the body), and checkpatch detects no proper commit body description.

Commit fc647a8 ("QCLINUX: arm64: dts: qcom: Fix GPIO free and acquire logic..."):

WARNING: Missing commit description - Add an appropriate one
fc647a8ed68a7d50d7cddc7111014addd57c064f total: 0 errors, 1 warnings, 0 checks, 400 lines checked

Same issue — long subject wrapping into body, no proper commit description.

Fix:

  1. For ad5b447 — Split into two patches:

    git rebase -i <base_sha>
    # Mark ad5b44728a67 as 'edit'
    # Create patch 1: dt-bindings header changes only
    git reset HEAD~1
    git add include/dt-bindings/mailbox/qcom-ipcc.h
    git commit -m "QCLINUX: dt-bindings: mailbox: qcom-ipcc: Add SAIL client IDs"
    # Create patch 2: DTS overlay
    git add arch/arm64/boot/dts/qcom/
    git commit -m "QCLINUX: arm64: dts: qcom: lemans: Add SAIL Mailbox device tree overlay"
    git rebase --continue
  2. For b7de1d7 and fc647a8 — Rewrite commit messages with proper subject/body separation:

    git rebase -i <base_sha>
    # Mark each commit as 'reword'
    # For b7de1d752e12:
    Subject: QCLINUX: arm64: dts: qcom: Enable combo mode for CSI1 port
    
    In order to enable combo mode on CSI1, resources need to be in shared
    mode. This change adds required resources under the res-mgr node.
    
    # For fc647a8ed68a:
    Subject: QCLINUX: arm64: dts: qcom: Fix GPIO free and acquire logic
    
    Prevent GPIOs managed by pinctrl from being requested and freed via
    the GPIO framework. Restrict GPIO request/free operations to
    non-pinctrl GPIOs by adding appropriate conditions.

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git df3ae9703774b70a7b7758b53498a25de9f87174..76c362df2aedc0c3d3a9ddac970755f10784ed34

❌ dtb-check

Root cause: Multiple dtb-check warnings, but all are pre-existing tree issues not introduced by this PR.

Failure details:

The PR adds only lemans-sail-mb.dtso (a new overlay), hamoa-camx-el2.dtso, and purwa-camx-el2.dtso. The dtb-check log shows errors in:

  1. monaco.dtsiusb-typec@47 interrupt cells mismatch (recurring issue, see log-patterns.md Section 8)
  2. hamoa-camera.dtsireg_format warnings on camera nodes (pre-existing, not touched by this PR)
  3. qcs6490-rb3gen2-industrial-mezzanine.dtsoreg_format and avoid_default_addr_size warnings (pre-existing)
  4. kodiak.dtsi, sm8750.dtsigraph_endpoint warnings (pre-existing)

None of these files are modified by PR #1294. The PR only adds new .dtso files for lemans, hamoa, and purwa. The dtb-check failures are baseline tree issues exposed when building the full DTB set.

Fix: No action required for this PR. These are tree-wide issues that should be fixed separately.

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/lemans-sail-mb.dtbo
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/hamoa-evk-camx.dtbo

❌ check-patch-compliance

Root cause: All 6 commits fail prefix validation because QCLINUX: and PENDING: are not in the checker's allowed prefix list.

Failure details:

Checking commit: arm64: dts: qcom: hamoa: add CAMX EL2 overlay
Commit summary does not start with a required prefix

Checking commit: QCLINUX: arm64: dts: qcom: add Purwa CAMX EL2 overlay
Commit summary does not start with a required prefix

Checking commit: QCLINUX: arm64: dts: qcom: Enable combo mode for CSI1 port...
Commit summary does not start with a required prefix

Checking commit: QCLINUX: arm64: dts: qcom: Fix GPIO free and acquire logic...
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: kaanapali: add Coresight ETR and routing in staging dtso
Commit summary does not start with a required prefix

Checking commit: QCLINUX: arm64: dts: qcom: lemans: Add SAIL Mailbox device tree overlay
Commit summary does not start with a required prefix

Analysis:

The check-patch-compliance checker only accepts these prefixes:

  • FROMLIST: (posted to mailing list)
  • FROMGIT: (in a maintainer tree)
  • UPSTREAM: (merged into mainline)
  • BACKPORT: (backported with modifications)

It rejects:

  • QCLINUX: (vendor-only, not upstream-linkable)
  • PENDING: (work-in-progress, not posted)
  • No prefix (commit a7c5882)

This is a known checker limitation (see log-patterns.md Section 7). Vendor-only commits with QCLINUX: or PENDING: prefixes will always fail this checker because they have no upstream Link: to validate against.

Fix:

If these commits are genuinely vendor-only with no upstream equivalent, the checker will continue to fail. This is expected behavior. However:

  1. Commit a7c5882 ("arm64: dts: qcom: hamoa: add CAMX EL2 overlay") has no prefix — add QCLINUX: to the subject:

    git rebase -i <base_sha>
    # Mark a7c58823f27f as 'reword'
    # Change subject to: QCLINUX: arm64: dts: qcom: hamoa: add CAMX EL2 overlay
  2. For the other 5 commits with QCLINUX: or PENDING: — if they are truly vendor-only, accept that check-patch-compliance will fail. If any have been posted upstream, change the prefix to FROMLIST: and add a Link: tag.

Reproduce locally:

# The checker script is in kernel-checkers repo
bash ../kernel-checkers/check-patch-compliance.sh --kernel-src . --base <base> --head <head>

❌ tag-check

Root cause: Commit a7c5882 has no subject-line prefix tag.

Failure details:

Commit a7c5882 ("arm64: dts: qcom: hamoa: add CAMX EL2 overlay") does not start with a required prefix.

All branches except qcom-next and qcom-next-staging require every commit subject to start with one of:

  • FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:

Fix:

git rebase -i <base_sha>
# Mark a7c58823f27f as 'reword'
# Change subject to: QCLINUX: arm64: dts: qcom: hamoa: add CAMX EL2 overlay
git rebase --continue

Choose QCLINUX: if this is a vendor-only change with no upstream equivalent.


Verdict

3 blockers must be fixed before merge:

  1. checkpatch — Split ad5b447 into two patches (dt-bindings header separate from DTS overlay); rewrite commit messages for b7de1d7 and fc647a8 with proper subject/body separation.
  2. check-patch-compliance — Add QCLINUX: prefix to commit a7c5882. Accept that vendor-only commits (QCLINUX:, PENDING:) will fail this checker (known limitation).
  3. tag-check — Add QCLINUX: prefix to commit a7c5882 (same fix as dummy change #2).

Non-blockers:

  • dtb-check failures are pre-existing tree issues, not introduced by this PR.
  • sparse-check, check-uapi-headers, dt-binding-check all passed.

@snegi-qti

Copy link
Copy Markdown
Author

I am checking the kernel-checker errors, shall share an update patch by tomorrow.

snegi-qti added 2 commits June 3, 2026 02:44
Add IPCC_CLIENT_SAIL0/1/2/3 client ID definitions (27-30) to
the qcom-ipcc dt-bindings header for use by the SAIL Mailbox
device tree overlay.

Signed-off-by: Sankalp Negi <snegi@qti.qualcomm.com>
Add lemans-sail-mb.dtso overlay for Lemans platform providing:
  - ipcc_computeL1: IPCC Compute-L1 controller
  - sail_mailbox: SAIL Mailbox device node.

Signed-off-by: Sankalp Negi <snegi@qti.qualcomm.com>
@qcomlnxci qcomlnxci requested a review from a team June 3, 2026 09:50
@qlijarvis

Copy link
Copy Markdown

PR #1294 — validate-patch

PR: #1294

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1294 - Add SAIL Mailbox support for Lemans platform
Upstream commit: N/A (vendor-only QCLINUX patches)
Verdict: ✅ PASS

Commit Message - Patch 1/2

Check Status Note
Subject matches upstream N/A Vendor-only (QCLINUX: prefix)
Body preserves rationale Clear description of IPCC client IDs being added
Fixes tag present/correct N/A New feature, not a fix
Authorship preserved Sankalp Negi snegi@qti.qualcomm.com
Backport note (if applicable) N/A Original vendor contribution

Commit Message - Patch 2/2

Check Status Note
Subject matches upstream N/A Vendor-only (QCLINUX: prefix)
Body preserves rationale Lists overlay components (ipcc_computeL1, sail_mailbox)
Fixes tag present/correct N/A New feature, not a fix
Authorship preserved Sankalp Negi snegi@qti.qualcomm.com
Backport note (if applicable) N/A Original vendor contribution

Diff

File Status Notes
include/dt-bindings/mailbox/qcom-ipcc.h Adds 4 SAIL client IDs (27-30) in correct sequence
arch/arm64/boot/dts/qcom/Makefile Adds lemans-sail-mb.dtbo build target
arch/arm64/boot/dts/qcom/lemans-sail-mb.dtso New overlay with proper SPDX, copyright, structure

Technical Review

Patch 1 - dt-bindings additions:

  • ✅ Follows existing IPCC_CLIENT_* naming convention
  • ✅ Client IDs 27-30 fill gap between WPSS (24) and GPDSP0 (31)
  • ✅ Sequential numbering is correct
  • ✅ Placement preserves numerical ordering in header

Patch 2 - Device tree overlay:

  • ✅ Proper overlay structure with /dts-v1/ and /plugin/ directives
  • ✅ SPDX license identifier present (BSD-3-Clause)
  • ✅ Copyright notice included
  • ✅ Includes necessary dt-bindings headers
  • ✅ Uses newly defined IPCC_CLIENT_SAIL* constants from patch 1
  • ✅ Defines ipcc_computeL1 controller and sail_mailbox device
  • ✅ References external memory regions (sail_mailbox_mem, sail_ota_mem)
  • ✅ Proper interrupt and mailbox channel configuration
  • ✅ Makefile integration correct

Verdict

Merge as-is. Both patches are well-formed vendor-only contributions with clear commit messages, proper authorship, correct SPDX licensing, and technically sound changes. The dt-bindings additions follow kernel conventions, and the device tree overlay is properly structured.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

@qlijarvis

Copy link
Copy Markdown

PR #1294 — checker-log-analyzer

PR: #1294
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26877087047

Checker Result Summary
Checker Result Summary
checkpatch All commits pass checkpatch style checks
dt-binding-check ⏭️ Skipped - no changes to Documentation/devicetree/bindings
dtb-check DTB compilation successful (pre-existing warnings unrelated to PR)
sparse-check Sparse static analysis passed
check-uapi-headers No UAPI header changes detected
check-patch-compliance BLOCKER: Commits missing required UPSTREAM:/FROMLIST:/BACKPORT: prefix
tag-check N/A Not applicable for topic branches
qcom-next-check N/A Not applicable for topic branches

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1294 - Add SAIL Mailbox support for Lemans platform
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26877087047

Checker Result Summary
checkpatch All commits pass checkpatch style checks
dt-binding-check ⏭️ Skipped - no changes to Documentation/devicetree/bindings
dtb-check DTB compilation successful (pre-existing warnings unrelated to PR)
sparse-check Sparse static analysis passed
check-uapi-headers No UAPI header changes detected
check-patch-compliance BLOCKER: Commits missing required UPSTREAM:/FROMLIST:/BACKPORT: prefix
tag-check N/A Not applicable for topic branches
qcom-next-check N/A Not applicable for topic branches

❌ check-patch-compliance

Root cause: Both commits in this PR use the QCLINUX: prefix, which is not allowed in the kernel-topics repository. The check-patch-compliance checker requires all commits to use upstream-style prefixes.

Failure details:

2026-06-03T10:06:15.2249818Z Checking commit: QCLINUX: dt-bindings: mailbox: qcom-ipcc: Add SAIL client IDs
2026-06-03T10:06:15.2264964Z Commit summary does not start with a required prefix

2026-06-03T10:06:15.2316191Z Checking commit: QCLINUX: arm64: dts: qcom: lemans: Add SAIL Mailbox device tree overlay
2026-06-03T10:06:15.2331710Z Commit summary does not start with a required prefix

2026-06-03T10:06:15.2349943Z ##[error]Process completed with exit code 1.

Fix: Update both commit subject lines to use one of the required prefixes:

  • UPSTREAM: - for patches already merged in mainline Linux
  • FROMLIST: - for patches posted to upstream mailing lists but not yet merged
  • BACKPORT: - for patches backported from a newer kernel version
  • PENDING: - for patches intended for upstream submission

Since these appear to be Qualcomm-specific additions (SAIL mailbox support, vendor-specific client IDs), the appropriate prefix is likely PENDING: if they are intended for upstream submission, or the commits should be moved to a different branch (qcom-next or qcom-next-staging) where QCLINUX: prefix is acceptable.

Recommended action:

# Reword both commits to use PENDING: prefix
git rebase -i HEAD~2
# Change 'pick' to 'reword' for both commits
# Update subjects to:
#   PENDING: dt-bindings: mailbox: qcom-ipcc: Add SAIL client IDs
#   PENDING: arm64: dts: qcom: lemans: Add SAIL Mailbox device tree overlay

Reproduce locally:

git clone https://github.com/qualcomm-linux/kernel-checkers.git
cd kernel-checkers
./check-patch-compliance.sh --kernel-src /path/to/kernel --base <base-sha> --head <pr-head-sha>

Verdict

1 blocker to fix: All commits must use UPSTREAM:/FROMLIST:/BACKPORT:/PENDING: prefix instead of QCLINUX:. Once commit messages are updated, all other checkers pass cleanly.

@Komal-Bajaj Komal-Bajaj merged commit ae662f2 into qualcomm-linux:tech/overlay/dt Jun 3, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants