Skip to content

Commit ab99d78

Browse files
Viken Dadhaniyaquic-kaushalk
authored andcommitted
FROMLIST: arm64: dts: qcom: sa8775p: Add default pin configurations for QUP SEs
Default pinctrl configurations for all QUP (Qualcomm Universal Peripheral) Serial Engines (SEs) are missing in the SoC device tree. These configurations are required by client teams when enabling any SEs as I2C, SPI, or Serial protocols. Add default pin configurations for Serial Engines (SEs) for all supported protocols, including I2C, SPI, and UART, to the sa8775p device tree. This change facilitates slave device driver clients to enable usecase with minimal modifications. Remove duplicate pin configurations from target-specific file as same pin configuration is included in the SoC device tree. Link: https://lore.kernel.org/r/20250509090443.4107378-1-quic_vdadhani@quicinc.com Acked-by: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com> Signed-off-by: Viken Dadhaniya <quic_vdadhani@quicinc.com>
1 parent 6e5b404 commit ab99d78

File tree

2 files changed

+797
-86
lines changed

2 files changed

+797
-86
lines changed

arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi

Lines changed: 47 additions & 86 deletions
Original file line numberDiff line numberDiff line change
@@ -510,15 +510,11 @@
510510

511511
&i2c11 {
512512
clock-frequency = <400000>;
513-
pinctrl-0 = <&qup_i2c11_default>;
514-
pinctrl-names = "default";
515513
status = "okay";
516514
};
517515

518516
&i2c18 {
519517
clock-frequency = <400000>;
520-
pinctrl-0 = <&qup_i2c18_default>;
521-
pinctrl-names = "default";
522518
status = "okay";
523519
};
524520

@@ -672,6 +668,53 @@
672668
status = "okay";
673669
};
674670

671+
&qup_spi16_default {
672+
drive-strength = <6>;
673+
bias-disable;
674+
};
675+
676+
&qup_i2c11_default {
677+
drive-strength = <2>;
678+
bias-pull-up;
679+
};
680+
681+
&qup_i2c18_default {
682+
drive-strength = <2>;
683+
bias-pull-up;
684+
};
685+
686+
&qup_uart12_cts {
687+
bias-disable;
688+
};
689+
690+
&qup_uart12_rts {
691+
bias-pull-down;
692+
};
693+
694+
&qup_uart12_tx {
695+
bias-pull-up;
696+
};
697+
698+
&qup_uart12_rx {
699+
bias-pull-down;
700+
};
701+
702+
&qup_uart17_cts {
703+
bias-disable;
704+
};
705+
706+
&qup_uart17_rts {
707+
bias-pull-down;
708+
};
709+
710+
&qup_uart17_tx {
711+
bias-pull-up;
712+
};
713+
714+
&qup_uart17_rx {
715+
bias-pull-down;
716+
};
717+
675718
&serdes0 {
676719
phy-supply = <&vreg_l5a>;
677720
status = "okay";
@@ -687,8 +730,6 @@
687730
};
688731

689732
&spi16 {
690-
pinctrl-0 = <&qup_spi16_default>;
691-
pinctrl-names = "default";
692733
status = "okay";
693734
};
694735

@@ -721,84 +762,6 @@
721762
};
722763
};
723764

724-
qup_uart10_default: qup-uart10-state {
725-
pins = "gpio46", "gpio47";
726-
function = "qup1_se3";
727-
};
728-
729-
qup_spi16_default: qup-spi16-state {
730-
pins = "gpio86", "gpio87", "gpio88", "gpio89";
731-
function = "qup2_se2";
732-
drive-strength = <6>;
733-
bias-disable;
734-
};
735-
736-
qup_i2c11_default: qup-i2c11-state {
737-
pins = "gpio48", "gpio49";
738-
function = "qup1_se4";
739-
drive-strength = <2>;
740-
bias-pull-up;
741-
};
742-
743-
qup_i2c18_default: qup-i2c18-state {
744-
pins = "gpio95", "gpio96";
745-
function = "qup2_se4";
746-
drive-strength = <2>;
747-
bias-pull-up;
748-
};
749-
750-
qup_uart12_default: qup-uart12-state {
751-
qup_uart12_cts: qup-uart12-cts-pins {
752-
pins = "gpio52";
753-
function = "qup1_se5";
754-
bias-disable;
755-
};
756-
757-
qup_uart12_rts: qup-uart12-rts-pins {
758-
pins = "gpio53";
759-
function = "qup1_se5";
760-
bias-pull-down;
761-
};
762-
763-
qup_uart12_tx: qup-uart12-tx-pins {
764-
pins = "gpio54";
765-
function = "qup1_se5";
766-
bias-pull-up;
767-
};
768-
769-
qup_uart12_rx: qup-uart12-rx-pins {
770-
pins = "gpio55";
771-
function = "qup1_se5";
772-
bias-pull-down;
773-
};
774-
};
775-
776-
qup_uart17_default: qup-uart17-state {
777-
qup_uart17_cts: qup-uart17-cts-pins {
778-
pins = "gpio91";
779-
function = "qup2_se3";
780-
bias-disable;
781-
};
782-
783-
qup_uart17_rts: qup0-uart17-rts-pins {
784-
pins = "gpio92";
785-
function = "qup2_se3";
786-
bias-pull-down;
787-
};
788-
789-
qup_uart17_tx: qup0-uart17-tx-pins {
790-
pins = "gpio93";
791-
function = "qup2_se3";
792-
bias-pull-up;
793-
};
794-
795-
qup_uart17_rx: qup0-uart17-rx-pins {
796-
pins = "gpio94";
797-
function = "qup2_se3";
798-
bias-pull-down;
799-
};
800-
};
801-
802765
pcie0_default_state: pcie0-default-state {
803766
perst-pins {
804767
pins = "gpio2";
@@ -926,8 +889,6 @@
926889

927890
&uart10 {
928891
compatible = "qcom,geni-debug-uart";
929-
pinctrl-0 = <&qup_uart10_default>;
930-
pinctrl-names = "default";
931892
status = "okay";
932893
};
933894

0 commit comments

Comments
 (0)