Skip to content

Commit c760bcd

Browse files
superm1alexdeucher
authored andcommitted
drm/amd: Check whether secure display TA loaded successfully
[Why] Not all renoir hardware supports secure display. If the TA is present but the feature isn't supported it will fail to load or send commands. This shows ERR messages to the user that make it seems like there is a problem. [How] Check the resp_status of the context to see if there was an error before trying to send any secure display commands. Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/1415 Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent 7574f30 commit c760bcd

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2352,7 +2352,7 @@ static int psp_securedisplay_initialize(struct psp_context *psp)
23522352
}
23532353

23542354
ret = psp_ta_load(psp, &psp->securedisplay_context.context);
2355-
if (!ret) {
2355+
if (!ret && !psp->securedisplay_context.context.resp_status) {
23562356
psp->securedisplay_context.context.initialized = true;
23572357
mutex_init(&psp->securedisplay_context.mutex);
23582358
} else

0 commit comments

Comments
 (0)