networkmanager: ensure Wi-Fi VIFs are created before NM activates con…#274
networkmanager: ensure Wi-Fi VIFs are created before NM activates con…#274WeiZhang-stone wants to merge 1 commit intoqualcomm-linux:mainfrom
Conversation
lumag
left a comment
There was a problem hiding this comment.
- Drop Gerrit tag
- Describe the problem you are trying to solve first, before describing the solution.
| @@ -0,0 +1,178 @@ | |||
| #!/bin/sh | |||
| # /usr/libexec/nm-wifi-vif-create.sh | |||
There was a problem hiding this comment.
Drop this and add SDPX / Copyright.
Why is this needed? Please explain the issue that caused this change to be proposed. |
|
Thank you for the review.
Sure, here is the background: On ath11k/ath12k platforms, the wireless driver only creates the base In multi-interface deployments such as AP+AP+STA, the AP connection This systemd oneshot service fills the gap by creating the required I will update the commit message accordingly in v2. |
7ca8dad to
2b46420
Compare
|
Change-Id is still there. |
|
Can we restrict this only for ath11k/ath12k? |
The issue this service addresses is not specific to ath11k/ath12k. The typical use case is: the user configures multiple VIFs and This service is not enabled by default — it is an opt-in option. Keeping it generic would allow any platform to benefit from it, Thanks, |
|
I will update the commit message in v3 to remove the ath11k/ath12k Thanks, |
|
If really generic this should not be qcom specific change, so it would be material for either NM or meta-oe. |
Apologies for the misleading description earlier. Let me clarify: Creating VIFs for NetworkManager before it starts is a general The script contains logic driven by ath11k/ath12k interface Thanks, |
…nections The wireless driver typically creates only the base STA interface (e.g., wlP4p1s0) at probe time. NetworkManager does not create Wi-Fi interfaces - it only manages existing ones. In multi-VIF deployments (e.g., AP+AP+STA), the connection profiles reference VIFs that do not exist at boot, causing NM to fail activating these connections. Add a systemd oneshot service to create the required VIFs before NM activates the connections. The service is not enabled by default. When enabled, it tries to wait for the STA to connect first before creating AP VIFs, avoiding mutual interference between AP operation and STA's scanning/association process on the shared radio. Signed-off-by: Wei Zhang <wei.zhang@oss.qualcomm.com>
2b46420 to
bceab90
Compare
Then explain this as part of the commit message and also add a comment inside the script explaining the logic and the reasoning for the script. |
Both ath11k and ath12k cards can be found on non-Qualcomm platforms. The script should be generalized and pushed upstream. |
networkmanager: ensure Wi-Fi VIFs are created before NM activates connections
The wireless driver typically creates only the base STA interface
(e.g., wlP4p1s0) at probe time. NetworkManager does not create
Wi-Fi interfaces - it only manages existing ones. In multi-VIF
deployments (e.g., AP+AP+STA), the connection profiles reference
VIFs that do not exist at boot, causing NM to fail activating
these connections.
Add a systemd oneshot service to create the required VIFs before NM
activates the connections. The service is not enabled by default.
When enabled, it tries to wait for the STA to connect first before
creating AP VIFs, avoiding mutual interference between AP operation
and STA's scanning/association process on the shared radio.