Skip to content

Commit c793f79

Browse files
ricardosalvetimwasilew
authored andcommitted
ci: test-job-summary: report test results from Incomplete jobs
LAVA test jobs that finish with health Incomplete (e.g. the device crashed or timed out partway through the run) still carry valid test results for everything that ran before the failure, but the summary only fetched suite results for jobs that were both Finished and Complete, discarding Incomplete test jobs entirely. This is worse now that stale re-run artifacts are de-duplicated to the newest LAVA job per device and test: if that newest job ends up Incomplete, the device would show no results at all and its failures would silently disappear from the summary. Require only the Finished state for test jobs so their partial results are reported; boot jobs keep the Complete requirement as their health is the result. Suggested-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com> Signed-off-by: Ricardo Salveti <ricardo.salveti@oss.qualcomm.com>
1 parent cfe55dc commit c793f79

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

.github/actions/test-job-summary/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ runs:
8484
TEST_RESULTS=$(for SUITE in $(echo "$JOB_SUITES" | jq -r -c ".results[]")
8585
do
8686
if [ "${JOB_TYPE}" = "test" ]; then
87-
if [ "${JOB_STATE}" = "Finished" ] && [ ${JOB_HEALTH} = "Complete" ]; then
87+
if [ "${JOB_STATE}" = "Finished" ]; then
8888
SUITE_NAME=$(echo "$SUITE" | jq -r ".name")
8989
SUITE_ID=$(echo "$SUITE" | jq -r ".id")
9090
SUITE_TESTS=$(curl -s "https://lava.infra.foundries.io/api/v0.2/jobs/$JOB_ID/suites/$SUITE_ID/tests/")

0 commit comments

Comments
 (0)