Skip to content

Commit f518aa0

Browse files
committed
qcom-common: centralize XBL config selection via QCOM_XBL_CONFIG
Avoid hardcoding XBL configuration logic in image_types_qcom, which limits flexibility for per-board virtualization control. Define QCOM_XBL_CONFIG in qcom-common.inc to select the appropriate XBL config based on COMBINED_FEATURES. This enables consistent KVM selection while allowing machine-level overrides when required. Signed-off-by: Viswanath Kraleti <viswanath.kraleti@oss.qualcomm.com>
1 parent e156427 commit f518aa0

2 files changed

Lines changed: 5 additions & 7 deletions

File tree

classes-recipe/image_types_qcom.bbclass

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -112,18 +112,13 @@ create_qcomflash_pkg() {
112112
done
113113

114114
# xbl_config
115-
xbl_config="xbl_config.elf"
116-
if ${@bb.utils.contains('DISTRO_FEATURES', 'kvm', 'true', 'false', d)}; then
117-
xbl_config="xbl_config_kvm.elf"
118-
fi
119-
120115
# Prefer the OEM-cert-injected xbl_config deployed by the capsule recipe
121116
# when available.
122117
if [ -n "${QCOM_CAPSULE_FIRMWARE}" ] && \
123118
[ -f "${DEPLOY_DIR_IMAGE}/xbl_config-with-oem-cert.elf" ]; then
124119
install -m 0644 "${DEPLOY_DIR_IMAGE}/xbl_config-with-oem-cert.elf" xbl_config.elf
125-
elif [ -f "${DEPLOY_DIR_IMAGE}/${QCOM_BOOT_FILES_SUBDIR}/${xbl_config}" ]; then
126-
install -m 0644 "${DEPLOY_DIR_IMAGE}/${QCOM_BOOT_FILES_SUBDIR}/${xbl_config}" xbl_config.elf
120+
elif [ -f "${DEPLOY_DIR_IMAGE}/${QCOM_BOOT_FILES_SUBDIR}/${QCOM_XBL_CONFIG}" ]; then
121+
install -m 0644 "${DEPLOY_DIR_IMAGE}/${QCOM_BOOT_FILES_SUBDIR}/${QCOM_XBL_CONFIG}" xbl_config.elf
127122
fi
128123

129124
# bootloader selection

conf/machine/include/qcom-common.inc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,9 @@ PREFERRED_PROVIDER_android-tools-conf = "android-tools-conf-configfs"
3636
IMAGE_FSTYPES ?= "ext4.gz"
3737
IMAGE_ROOTFS_ALIGNMENT ?= "4096"
3838

39+
# XBL Config selection
40+
QCOM_XBL_CONFIG ?= "${@bb.utils.contains("COMBINED_FEATURES", "kvm", "xbl_config_kvm.elf", "xbl_config.elf", d)}"
41+
3942
# Android boot image settings
4043
QCOM_BOOTIMG_KERNEL_BASE ?= "0x80000000"
4144
QCOM_BOOTIMG_PAGE_SIZE ?= "4096"

0 commit comments

Comments
 (0)