Skip to content

Install FastRPC by default#280

Merged
lool merged 2 commits intomainfrom
fastrpc-default
Feb 27, 2026
Merged

Install FastRPC by default#280
lool merged 2 commits intomainfrom
fastrpc-default

Conversation

@basak-qcom
Copy link
Copy Markdown
Contributor

@basak-qcom basak-qcom commented Feb 27, 2026

Now that we have hexagon-dsp-binaries and fastrpc packaging in trixie-overlay, install them by default.

Once #277 is landed, this should mean that fastrpc_test passes by default.

@github-actions
Copy link
Copy Markdown

Test Results

 2 files  ±0   6 suites  ±0   5m 10s ⏱️ ±0s
20 tests ±0  20 ✅ ±0  0 💤 ±0  0 ❌ ±0 
64 runs  ±0  64 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9cdfc19. ± Comparison against base commit 954dbc1.

Copy link
Copy Markdown
Contributor

@lool lool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; could you add a PR description?

Would you mind adding a line documenting overlays in README? (I realize it was there before your changes, it's slightly more visible now)

@lool
Copy link
Copy Markdown
Contributor

lool commented Feb 27, 2026

For the record, I have mixed feelings about fastrpc-tests instead of fastrpc-support; I feel this is something that should be pulled by some to-be-defined enablement testsuite, but it can be considered a developer health check tool for now.

@ndechesne
Copy link
Copy Markdown
Collaborator

I saw a discussion with @Srinivas-Kandagatla about the current package not being 'stable' and slightly outdated. Should we wait for the investigation before we install it by default? To avoid confusion with our users, who might need to override with a local build (or not.. depending on the investigation)?

@basak-qcom
Copy link
Copy Markdown
Contributor Author

Thank you for the review! PR description updated, and README.md entry added.

I saw a discussion with @Srinivas-Kandagatla about the current package not being 'stable' and slightly outdated. Should we wait for the investigation before we install it by default?

I appreciate the difficulty, but currently (apart from the kernel, see #277) our only known good test for this (fastrpc_test) is passing with this PR. I think qcom-deb-images should represent our current best Debian image even if it is flawed. That way it's a reproducible baseline that can be used to reproducibly perform this kind of investigation so that we can improve both functioning and tests (via CI). If we hold PRs back, then that will slow down progress as we won't make progress on the straightforward development tip with a downloadable image that just works that developers can use to do that.

For example, I have had my debusine repository live with this fastrpc build for over a month now, but developers haven't been testing that apparently, since no issues were reported until today.

The GitHub Action already sets this by default, but since we are going
to introduce packages to be installed by default that are only available
from this overlay, default to using the overlay in the debos recipe
itself.

Signed-off-by: Robie Basak <robie.basak@oss.qualcomm.com>
Now that we have hexagon-dsp-binaries and fastrpc packaging in
trixie-overlay, install them by default.

Once #277 is landed, this should mean that `fastrpc_test` passes by
default.

Signed-off-by: Robie Basak <robie.basak@oss.qualcomm.com>
@github-actions
Copy link
Copy Markdown

Test jobs for commit d034093

@lool lool merged commit 20bc1fb into main Feb 27, 2026
12 checks passed
@github-actions
Copy link
Copy Markdown

Test jobs for commit 7f9cf8a

@lool
Copy link
Copy Markdown
Contributor

lool commented Feb 28, 2026

This bumped rootfs size significantly, but this wasn't visible in the build-on-push or daily builds, probably due to differences with the kernel. I've submitted #286 to bump the rootfs size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants