fix(monza): Add Monaco initramfs firmware overlay#305
Conversation
|
Tip for shellcheck: use |
e51c8ec to
69c66d1
Compare
Done, thanks! |
|
Koen Kooi (@koenkooi) I have a different set of files than yours; can you confirm? |
|
I'm going to move this back to draft until Koen confirms the list of firmware that isn't loaded from initramfs-tools is critical for monza to work |
Test jobs for commit e51c8ec |
Test jobs for commit 69c66d1 |
I think I have the same list: |
Agathe Porte (gagath)
left a comment
There was a problem hiding this comment.
I really want the hook to fail if some of the firmware is not found instead of silently succeeding.
| /lib/firmware/qcom/qcs8300/gpdsp0.mbn \ | ||
| /lib/firmware/qcom/qcs8300/qupv3fw.elf | ||
| do | ||
| if [ -f "$fw" ]; then |
There was a problem hiding this comment.
don’t we want to fail if the firmware files are not present in the first place? this hook will silently fail if the files are not found
There was a problem hiding this comment.
I do not see this if removed from your last push?
But you're testing with dracut, I'm interested in the initramfs-tools gaps |
|
Ok, went through installing a kernel locally, and then the initrd contains more modules and they lack their firmware; boot results in: |
69c66d1 to
c75cb67
Compare
Changed to fail if missing; errors look like this: Tested the latest version, here's the different between initramfs from pre-built image, and after running update-initramfs -u: |
Test jobs for commit c75cb67 |
|
Github says there are no changes between commits after your last push, can you check that you added your changes? I am expecting for the |
Add workaround-initramfs-firmware-monaco overlay to ensure Monaco-specific firmware files are included in the initramfs. Use this workaround for linux-daily-monza images. See qualcomm-linux#258 Signed-off-by: Loïc Minier <loic.minier@oss.qualcomm.com>
Urgh, pushed again, sorry |
c75cb67 to
b3920c8
Compare
Test jobs for commit b3920c8 |
Add workaround-initramfs-firmware-monaco overlay to ensure
Monaco-specific firmware files are included in the initramfs.
Use this workaround for linux-daily-monza images.
See #258