Skip to content

Commit 5446ea4

Browse files
authored
Merge pull request #128 from azharsha/contributing
CONTRIBUTING.md: Add pre-requisties before pushing changes
2 parents 9fe4857 + 56cff54 commit 5446ea4

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

CONTRIBUTING.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,10 @@ In general, contributors should develop on branches based off of `main` and pull
1515
1. Create a new branch based on `main`: `git checkout -b <my-branch-name> main`.
1616
1. Make your changes, add tests, and make sure the tests still pass.
1717
1. Commit your changes using the [DCO](http://developercertificate.org/). You can attest to the DCO by commiting with the **-s** or **--signoff** options or manually adding the "Signed-off-by":
18+
1. Before pushing changes for review, run the following commands locally:
19+
- `export PTOOL_SEED=qcom-ptool-ci`
20+
- `make lint`
21+
- `make all integration check-checksums`
1822
1. Push to your fork and submit a pull request from your branch to `main`.
1923
1. Pat yourself on the back and wait for your pull request to be reviewed.
2024

0 commit comments

Comments
 (0)