check-missing-files: handle multi-disk file paths

Use a proper XML parser (python3 xml.etree, part of stdlib) instead of sed to
extract file_name and file_path from contents.xml, combining them into
relative paths. Match known filenames against the basename so that files in
storage-type subdirectories (e.g. spinor/gpt_main0.bin) are recognized
correctly, while checking existence with the full path.

Don't check presence of sail_nor/ files that ptool might generate as these are
not currently generated.

Signed-off-by: Loïc Minier <loic.minier@oss.qualcomm.com>

Author: lool

tests/integration/check-missing-files

@@ -3,7 +3,8 @@
 # SPDX-License-Identifier: BSD-3-Clause-Clear
 
 # Takes rawprogram*.xml and contents.xml files as arguments, collects the
-# filenames referenced, and checks if any gpt_* or zeros_* file is missing
+# filenames referenced, and checks if any gpt_* or zeros_* file is missing and
+# if the filenames are known
 
 set -eu
 
@@ -14,15 +15,36 @@ for xml in "$@"; do
     rawprogram_filenames="$(
         sed -En 's:.*filename="([^"]+)".*:\1:p' "${xml}"
     )"
+    # for contents.xml, extract file_path/file_name pairs as relative paths
     contents_filenames="$(
-        sed -En 's:.*<file_name>([^<]+)</file_name>.*:\1:p' "${xml}"
+        python3 -c "
+import xml.etree.ElementTree as ET, sys
+tree = ET.parse(sys.argv[1])
+for el in tree.iter():
+    fn = el.find('file_name')
+    fp = el.find('file_path')
+    if fn is not None and fn.text:
+        # construct relative path by combining file_path and file_name, but only
+        # if file_path is non-empty and not '.'
+        path = fp.text.rstrip('/') if fp is not None and fp.text and fp.text != '.' else ''
+        print(path + '/' + fn.text if path else fn.text)
+" "${xml}" 2>/dev/null
     )"
     for file in $(
         echo ${rawprogram_filenames} ${contents_filenames} | sort -u
         ); do
-        case "${file}" in
-          # expected files that should be generated by ptool
+        # for matching known filenames, use the basename (strip subdir from
+        # contents.xml file_path); for checking file existence, use the
+        # full relative path
+        basename="${file##*/}"
+        case "${basename}" in
+          # expected files that should be generated by ptool: test if present
           gpt_*|zeros_*|patch*.xml|rawprogram*.xml)
+            # except we don't generate SAIL programming files at the moment, so
+            # don't test if these are present
+            if [ "${file%/*}" = "./sail_nor" ]; then
+                continue
+            fi
             if ! [ -r "${dir}/${file}" ]; then
                 errors=yes
                 echo "Missing ${file} referenced in ${xml}" >&2