Skip to content

platforms/iq-615-evk: Add contents.xml.in#126

Merged
lumag merged 1 commit into
qualcomm-linux:mainfrom
azharsha:iq-615-evk_contents_xml
Jun 23, 2026
Merged

platforms/iq-615-evk: Add contents.xml.in#126
lumag merged 1 commit into
qualcomm-linux:mainfrom
azharsha:iq-615-evk_contents_xml

Conversation

@azharsha

@azharsha azharsha commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Add contents.xml.in file for IQ-615-EVK board. Add it to both emmc and ufs. This helps Axiom to run successfully end to end.

@azharsha azharsha mentioned this pull request Jun 19, 2026
Open
lumag
lumag previously approved these changes Jun 19, 2026
View reviewed changes
@lumag lumag enabled auto-merge June 19, 2026 11:01
auto-merge was automatically disabled June 22, 2026 04:06

Head branch was pushed to by a user without write access

@azharsha azharsha requested a review from lumag June 22, 2026 04:06
@lumag

lumag commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Why is checksum update a separate commit?

@azharsha

azharsha commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

Why is checksum update a separate commit?

To keep it separate from the actual change.

@lumag

lumag commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Why is checksum update a separate commit?

To keep it separate from the actual change.

Without the checksum update the tree is broken. Don't create broken commits, they break git bisect.

@azharsha

azharsha commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

Why is checksum update a separate commit?

To keep it separate from the actual change.

Without the checksum update the tree is broken. Don't create broken commits, they break git bisect.

Agreed, makes sense will squash the two commits.

@azharsha azharsha force-pushed the iq-615-evk_contents_xml branch from 954770d to cb3448e Compare June 22, 2026 07:56
@ricardosalveti

ricardosalveti commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Why is the contents.xml.in changes are changing so many hashes? Are you using the same PTOOL_SEED used by our CI (qcom-ptool-ci)?

@azharsha azharsha force-pushed the iq-615-evk_contents_xml branch from cb3448e to 83eb8c5 Compare June 23, 2026 10:18
@azharsha

azharsha commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Why is the contents.xml.in changes are changing so many hashes? Are you using the same PTOOL_SEED used by our CI (qcom-ptool-ci)?

I had not done earlier. Now, after using PTOOL_SEED and compiled, checksum shows only the added files.
Also these command run by build ci are successful now.

make lint && make all integration check-checksums

Maybe the instruction to run

export PTOOL_SEED=qcom-ptool-ci
make generate-checksums
make check-cheksums

before pushing the change can be added to the README.md or CONTRIBUTING.md file.

@azharsha
platforms/iq-615-evk: Add contents.xml.in
635178c 
Add contents.xml.in file for IQ-615-EVK board. Add it to both emmc and ufs.
This helps Axiom to run successfully end to end.
Also update the integration test checksum manifest.

Signed-off-by: Azhar Shaikh <azhashai@qti.qualcomm.com>
@azharsha azharsha force-pushed the iq-615-evk_contents_xml branch from 83eb8c5 to 635178c Compare June 23, 2026 10:50
@lumag

lumag commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Maybe the instruction to run

export PTOOL_SEED=qcom-ptool-ci
make generate-checksums
make check-cheksums

before pushing the change can be added to the README.md or CONTRIBUTING.md file.

Please open the PR updating CONTRIBUTING.md file.

@azharsha

azharsha commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Maybe the instruction to run

export PTOOL_SEED=qcom-ptool-ci
make generate-checksums
make check-cheksums

before pushing the change can be added to the README.md or CONTRIBUTING.md file.

Please open the PR updating CONTRIBUTING.md file.

Sure will do!

@azharsha

azharsha commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Maybe the instruction to run

export PTOOL_SEED=qcom-ptool-ci
make generate-checksums
make check-cheksums

before pushing the change can be added to the README.md or CONTRIBUTING.md file.

Please open the PR updating CONTRIBUTING.md file.

Please help review: #128

@azharsha azharsha changed the title platforms/contents.xml.in: Add contents.xml.in platforms/iq-615-evk: Add contents.xml.in Jun 23, 2026
@lumag lumag enabled auto-merge June 23, 2026 18:28
@lumag lumag merged commit 6cc534e into qualcomm-linux:main Jun 23, 2026
3 checks passed
@azharsha azharsha deleted the iq-615-evk_contents_xml branch June 24, 2026 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lumag lumag lumag approved these changes

@vkraleti vkraleti Awaiting requested review from vkraleti vkraleti is a code owner

@ndechesne ndechesne Awaiting requested review from ndechesne ndechesne is a code owner

+1 more reviewer

@ricardosalveti ricardosalveti ricardosalveti approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@azharsha @lumag @ricardosalveti