Split config files into UI and pinout fragments#54
Open
Milosz Wasilewski (mwasilew) wants to merge 3 commits into
Open
Split config files into UI and pinout fragments#54Milosz Wasilewski (mwasilew) wants to merge 3 commits into
Milosz Wasilewski (mwasilew) wants to merge 3 commits into
Conversation
When using CMake=3.22 as advertised in the top level CMakeLists.txt, the build fails because of how cmake expands lists. This version of cmake treats the target_link_libraries argument as a list and splits on ; before evaluating the generator expression — tearing $<$<CONFIG:Debug>:foo;bar> into $<1:foo + bar + bar> and leaking the broken fragments to the linker. Proper syntax demands quotations. This feature changes in version 3.23 Kitware/CMake@c1e812ad4f3 Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>
Original configuration files describe both automation interface pinout and the UI for Qt application to present the controls. This patch splits the UI and pinout into separate files. This allows to re-use the pinout files without carrying any UI related configs. Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>
Split the schema files into two following the split of the config files themselves. This allows to validate the pinout and UI config files separately. Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Split the config files into UI and pinout related parts. This will allow to re-use the pinout files externally without carrying all the UI related configs
Type of Change
Please delete options that are not relevant.
Checklist