Disable floret detection by default (#196)

---
Signed-off-by: Kartik Nema <kartnema@qti.qualcomm.com>

Author: kartnema

client/APIs/UrmAPIs.cpp

@@ -240,11 +240,11 @@ int8_t getProp(const char* prop, char* buffer, size_t bufferSize, const char* de
 
         // read the response
         char resultBuf[bufferSize];
+        memset(resultBuf, 0, sizeof(resultBuf));
         if(RC_IS_NOTOK(conn->readMsg(resultBuf, sizeof(resultBuf)))) {
             return -1;
         }
 
-        buffer[bufferSize - 1] = '\0';
         if(strncmp(resultBuf, "na", 2) == 0) {
             // Copy default value
             strncpy(buffer, defValue, bufferSize - 1);

contextual-classifier/CMakeLists.txt

@@ -22,7 +22,7 @@ set_target_properties(ContextualClassifier PROPERTIES
 target_include_directories(ContextualClassifier PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/Include)
 
 # floret detection and USE_FLORET macro using pkg-config
-option(ENABLE_FLORET "Build ML inference with floret support" ON)
+option(ENABLE_FLORET "Build ML inference with floret support" OFF)
 
 set(FLORET_FOUND FALSE)
 set(FLORET_LIBRARIES "")

tests/Component/ParserTests.cpp

@@ -276,52 +276,52 @@ URM_TEST(PropertyParsingTests, {
     {
         std::string resultBuffer;
 
-        int8_t propFound = submitPropGetRequest("test.debug.enabled", resultBuffer, "false");
+        size_t bytesWritten = submitPropGetRequest("test.debug.enabled", resultBuffer, "false");
 
-        E_ASSERT((propFound == true));
+        E_ASSERT((bytesWritten > 0));
         E_ASSERT((strcmp(resultBuffer.c_str(), "true") == 0));
     }
 
     {
         std::string resultBuffer;
 
-        int8_t propFound = submitPropGetRequest("test.current.worker_thread.count", resultBuffer, "false");
+        size_t bytesWritten = submitPropGetRequest("test.current.worker_thread.count", resultBuffer, "false");
 
-        E_ASSERT((propFound == true));
+        E_ASSERT((bytesWritten > 0));
         E_ASSERT((strcmp(resultBuffer.c_str(), "125") == 0));
     }
 
     {
         std::string resultBuffer;
 
-        int8_t propFound = submitPropGetRequest("test.historic.worker_thread.count", resultBuffer, "5");
+        size_t bytesWritten = submitPropGetRequest("test.historic.worker_thread.count", resultBuffer, "5");
 
-        E_ASSERT((propFound == false));
+        E_ASSERT((bytesWritten == 0));
         E_ASSERT((strcmp(resultBuffer.c_str(), "5") == 0));
     }
 
     {
         std::thread th1([&]{
             std::string resultBuffer;
-            int8_t propFound = submitPropGetRequest("test.current.worker_thread.count", resultBuffer, "false");
+            size_t bytesWritten = submitPropGetRequest("test.current.worker_thread.count", resultBuffer, "false");
 
-            E_ASSERT((propFound == true));
+            E_ASSERT((bytesWritten > 0));
             E_ASSERT((strcmp(resultBuffer.c_str(), "125") == 0));
         });
 
         std::thread th2([&]{
             std::string resultBuffer;
-            int8_t propFound = submitPropGetRequest("test.debug.enabled", resultBuffer, "false");
+            size_t bytesWritten = submitPropGetRequest("test.debug.enabled", resultBuffer, "false");
 
-            E_ASSERT((propFound == true));
+            E_ASSERT((bytesWritten > 0));
             E_ASSERT((strcmp(resultBuffer.c_str(), "true") == 0));
         });
 
         std::thread th3([&]{
             std::string resultBuffer;
-            int8_t propFound = submitPropGetRequest("test.doc.build.mode.enabled", resultBuffer, "false");
+            size_t bytesWritten = submitPropGetRequest("test.doc.build.mode.enabled", resultBuffer, "false");
 
-            E_ASSERT((propFound == true));
+            E_ASSERT((bytesWritten > 0));
             E_ASSERT((strcmp(resultBuffer.c_str(), "false") == 0));
         });