few corrections (#147)

Signed-off-by: rajulu <rajulu@qti.qualcomm.com>

Author: rajulup

contextual-classifier/ContextualClassifier.cpp

@@ -204,7 +204,7 @@ void ContextualClassifier::ClassifierMain() {
 
         if(ev.type == CC_APP_OPEN) {
             std::string comm;
-            uint32_t sigId = CONSTRUCT_SIG_CODE(URM_SIG_CAT_GENERIC, URM_SIG_APP_OPEN);
+            uint32_t sigId = URM_SIG_APP_OPEN;
             uint32_t sigType = DEFAULT_SIGNAL_TYPE;
             uint32_t ctxDetails = 0U;
 
@@ -367,17 +367,17 @@ void ContextualClassifier::RemoveActions(pid_t processPid, pid_t processTgid) {
 uint32_t ContextualClassifier::GetSignalIDForWorkload(int32_t contextType) {
     switch(contextType) {
         case CC_MULTIMEDIA:
-            return CONSTRUCT_SIG_CODE(URM_SIG_CAT_MULTIMEDIA, URM_SIG_MULTIMEDIA_APP_OPEN);
+            return URM_SIG_MULTIMEDIA_APP_OPEN;
         case CC_GAME:
-            return CONSTRUCT_SIG_CODE(URM_SIG_CAT_GAMING, URM_SIG_GAME_APP_OPEN);
+            return URM_SIG_GAME_APP_OPEN;
         case CC_BROWSER:
-            return CONSTRUCT_SIG_CODE(URM_SIG_CAT_BROWSER, URM_SIG_BROWSER_APP_OPEN);
+            return URM_SIG_BROWSER_APP_OPEN;
         default:
             break;
     }
 
     // CC_APP
-    return CONSTRUCT_SIG_CODE(URM_SIG_CAT_GENERIC, URM_SIG_APP_OPEN);
+    return URM_SIG_APP_OPEN;
 }
 
 void ContextualClassifier::LoadIgnoredProcesses() {

docs/README.md

@@ -201,10 +201,10 @@ The following signal codes are supported signals. Target or segment specific cus
 
 |       Signal Code             |  Code           |
 |-------------------------------|-----------------|
-|   URM_SIG_APP_OPEN            | 0x 00 02 0000   |
-|   URM_SIG_BROWSER_APP_OPEN    | 0x 00 02 0001   |
-|   URM_SIG_GAME_APP_OPEN       | 0x 00 02 0002   |
-|   URM_SIG_MULTIMEDIA_APP_OPEN | 0x 00 02 0003   |
+|   URM_SIG_APP_OPEN            | 0x 00 02 0001   |
+|   URM_SIG_BROWSER_APP_OPEN    | 0x 00 02 0002   |
+|   URM_SIG_GAME_APP_OPEN       | 0x 00 02 0003   |
+|   URM_SIG_MULTIMEDIA_APP_OPEN | 0x 00 02 0004   |
 
 The above mentioned list of enums are available in the interface file "UrmPlatformAL.h".
 
@@ -1379,8 +1379,8 @@ The Contextual Classifier is an optional module designed to identify the static
                  |
                  v
           +--------------+
-				  |    Action    |
-					+--------------+
+          |    Action    |
+          +--------------+
 ```
 
 

modula/Common/Include/UrmPlatformAL.h

@@ -231,30 +231,45 @@ static inline uint32_t getResCodeFromString(const char* strCode, int8_t* found)
     return 0;
 }
 
-// Predefined Signal Categories
+//Predefined Resource Types
 enum {
-    URM_SIG_CAT_TEST = 0x01,
-    URM_SIG_CAT_GENERIC = 0x02,
-    URM_SIG_CAT_MULTIMEDIA = 0x03,
-    URM_SIG_CAT_GAMING = 0x04,
-    URM_SIG_CAT_BROWSER = 0x05,
+	CPU_LPM    = 0x00,
+	CACHE_MGMT = 0x01,
+	CPU_SCHED  = 0x02,
+	CPU_FREQ   = 0x03,
+	GPU_OPP    = 0x04,
+	NPU_OPP    = 0x06,
+	MEMORY_QOS = 0x07,
+	MPAM_QOS   = 0x08,
+	CGRP_OPS   = 0x09,
+	STORAGE_IO = 0x0a,
+	CUSTOM     = 0x80
 };
 
-// Generic
+// Predefined Signal Categories
 enum {
-    URM_SIG_APP_OPEN = 0x0001,
-    URM_SIG_BROWSER_APP_OPEN = 0x0002,
-    URM_SIG_GAME_APP_OPEN = 0x0003,
-    URM_SIG_MULTIMEDIA_APP_OPEN = 0x0004,
+    URM_SIG_CAT_TEST       = 0x01,
+    URM_SIG_CAT_GENERIC    = 0x02,
+    URM_SIG_CAT_MULTIMEDIA = 0x03,
+    URM_SIG_CAT_GAMING     = 0x04,
+    URM_SIG_CAT_BROWSER    = 0x05,
+	URM_SIG_CAT_CUSTOM     = 0x80
 };
 
-// Multimedia
+//Signal codes
 enum {
-    URM_SIG_VIDEO_DECODE = 0x0001,
-    URM_SIG_CAMERA_PREVIEW = 0x0002,
-    URM_SIG_CAMERA_ENCODE = 0x0003,
-    URM_SIG_CAMERA_ENCODE_MULTI_STREAMS = 0x0004,
-    URM_SIG_ENCODE_DECODE = 0x0005,
+	// Generic
+    URM_SIG_APP_OPEN                    = 0x00020001,
+    URM_SIG_BROWSER_APP_OPEN            = 0x00020002,
+    URM_SIG_GAME_APP_OPEN               = 0x00020003,
+    URM_SIG_MULTIMEDIA_APP_OPEN         = 0x00020004,
+
+    // Multimedia
+    URM_SIG_VIDEO_DECODE                = 0x00030001,
+    URM_SIG_CAMERA_PREVIEW              = 0x00030002,
+    URM_SIG_CAMERA_ENCODE               = 0x00030003,
+    URM_SIG_CAMERA_ENCODE_MULTI_STREAMS = 0x00030004,
+    URM_SIG_ENCODE_DECODE               = 0x00030005,
 };
 
 #endif