Skip to content

Commit b0eb392

Browse files
authored
Additional Testcase for target-specific Signal Parsing (#241)
--- Signed-off-by: Kartik Nema <kartnema@qti.qualcomm.com>
1 parent 666dbfc commit b0eb392

3 files changed

Lines changed: 43 additions & 5 deletions

File tree

modula/CoreModules/AuxRoutines.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -268,6 +268,11 @@ int64_t AuxRoutines::getCurrentTimeInMilliseconds() {
268268
return std::chrono::duration_cast<std::chrono::milliseconds>(now.time_since_epoch()).count();
269269
}
270270

271+
void AuxRoutines::toLowerCase(std::string& str) {
272+
std::transform(str.begin(), str.end(), str.begin(),
273+
[](unsigned char c) { return std::tolower(c); });
274+
}
275+
271276
MinLRUCache::MinLRUCache(int32_t maxSize) {
272277
this->mMaxSize = maxSize;
273278
this->mDataSet.reserve(this->mMaxSize);
@@ -287,8 +292,3 @@ void MinLRUCache::insert(int64_t data) {
287292
int8_t MinLRUCache::isPresent(int64_t data) {
288293
return (this->mDataSet.find(data) != this->mDataSet.end());
289294
}
290-
291-
void AuxRoutines::toLowerCase(std::string& str) {
292-
std::transform(str.begin(), str.end(), str.begin(),
293-
[](unsigned char c) { return std::tolower(c); });
294-
}

tests/Component/ParserTests.cpp

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ URM_TEST(SignalParsingTests, {
8888
E_ASSERT((signalInfo != nullptr));
8989
E_ASSERT((signalInfo->mSignalID == 0));
9090
E_ASSERT((signalInfo->mSignalCategory == 0x0d));
91+
E_ASSERT((signalInfo->mSigType == 0));
9192
E_ASSERT((strcmp((const char*)signalInfo->mSignalName.data(), "TEST_SIGNAL_1") == 0));
9293
E_ASSERT((signalInfo->mTimeout == 4000));
9394

@@ -185,6 +186,33 @@ URM_TEST(SignalParsingTests, {
185186
E_ASSERT((resource2->getValueAt(3) == 512));
186187
E_ASSERT((resource2->getResInfo() == 0));
187188
}
189+
190+
{
191+
SignalInfo* signalInfo = SignalRegistry::getInstance()->getSignalConfigById(CONSTRUCT_SIG_CODE(0x0d, 0x000b), 27);
192+
193+
E_ASSERT((signalInfo != nullptr));
194+
E_ASSERT((signalInfo->mSignalID == 0x000b));
195+
E_ASSERT((signalInfo->mSignalCategory == 0x0d));
196+
E_ASSERT((signalInfo->mSigType == 27));
197+
E_ASSERT((strcmp((const char*)signalInfo->mSignalName.data(), "SIGNAL_WITH_SIGTYPE") == 0));
198+
E_ASSERT((signalInfo->mTimeout == 10000));
199+
200+
E_ASSERT((signalInfo->mPermissions != nullptr));
201+
E_ASSERT((signalInfo->mDerivatives == nullptr));
202+
E_ASSERT((signalInfo->mSignalResources != nullptr));
203+
204+
E_ASSERT((signalInfo->mPermissions->size() == 2));
205+
E_ASSERT((signalInfo->mSignalResources->size() == 1));
206+
207+
E_ASSERT((signalInfo->mPermissions->at(0) == PERMISSION_THIRD_PARTY));
208+
E_ASSERT((signalInfo->mPermissions->at(1) == PERMISSION_SYSTEM));
209+
210+
Resource* resource1 = signalInfo->mSignalResources->at(0);
211+
E_ASSERT((resource1->getResCode() == 0x00ff0004));
212+
E_ASSERT((resource1->getValuesCount() == 1));
213+
E_ASSERT((resource1->getValueAt(0) == 231));
214+
E_ASSERT((resource1->getResInfo() == 0));
215+
}
188216
})
189217

190218
URM_TEST(InitConfigParsingTests, {

tests/Configs/SignalsConfig.yaml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,3 +161,13 @@ SignalConfigs:
161161
- {ResCode: "0x00ff000a", ResInfo: "0x00000100", Values: [1989]} # logical cluster: 1
162162
- {ResCode: "0x00ff000a", ResInfo: "0x00000200", Values: [2012]} # logical cluster: 2
163163
- {ResCode: "0x00ff000d", ResInfo: "0x00000000", Values: [802, 41128]} # cgroup: audio
164+
165+
- SigId: "0x000b"
166+
Category: "0x0d"
167+
SigType: 27
168+
Name: SIGNAL_WITH_SIGTYPE
169+
Enable: true
170+
Permissions: ["third_party", "system"]
171+
Timeout: 10000
172+
Resources:
173+
- {ResCode: "0x00ff0004", ResInfo: "0x00000000", Values: [231]}

0 commit comments

Comments
 (0)